Linux USB
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: jjatczak@antmicro.com,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
	Zee Yudenko <zyudenko@internships.antmicro.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usbip: Don't print port status error for full-speed devices
Date: Fri, 20 Nov 2026 13:29:28 -0700	[thread overview]
Message-ID: <0f144e5d-db49-4251-a18d-3819fb30ebed@linuxfoundation.org> (raw)
In-Reply-To: <20261119-usbip-fix-v1-1-e6c04690115d@antmicro.com>

On 11/19/26 07:18, Jakub Jatczak via B4 Relay wrote:
> From: Zee Yudenko <zyudenko@internships.antmicro.com>
> 
> When getting port status for USBIP, we only check for high- and low-speed
> settings, but not for the full-speed, which causes an 'vhci_device speed
> not set' error to be printed whenever a full-speed device is attached. A
> full-speed device is the default status, so we don't need to set any port
> status bits.

Does the full speed  device
The change you are making doesn't match the change log.
> 
> Signed-off-by: Zee Yudenko <zyudenko@internships.antmicro.com>
> Signed-off-by: Jakub Jatczak <jjatczak@antmicro.com>
> ---
> Patch authored by Zee Yudenko; I'm submitting it on their behalf.
> Please direct feedback to me.
> ---
>   drivers/usb/usbip/vhci_hcd.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 39e8faf4c18c..936b98629921 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -480,6 +480,9 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>   					vhci_hcd->port_status[rhport] |=
>   					      USB_PORT_STAT_HIGH_SPEED;
>   					break;
> +				case USB_SPEED_FULL:
> +					/* this is the default, no flag needed */
> +					break;
>   				case USB_SPEED_LOW:
>   					vhci_hcd->port_status[rhport] |=
>   						USB_PORT_STAT_LOW_SPEED;

Why not remove the dev_err() under the default case?

default:
           dev_err(hcd_dev(hcd), "vhci_device speed not set\n");
                                         break;

thanks,
-- Shuah

      parent reply	other threads:[~2026-11-20 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:18 [PATCH] usbip: Don't print port status error for full-speed devices Jakub Jatczak via B4 Relay
2026-11-19 14:29 ` sashiko-bot
2026-11-20 20:29 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f144e5d-db49-4251-a18d-3819fb30ebed@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=i@zenithal.me \
    --cc=jjatczak@antmicro.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    --cc=zyudenko@internships.antmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox