Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jakub Jatczak" <jjatczak@antmicro.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usbip: Don't print port status error for full-speed devices
Date: Thu, 19 Nov 2026 14:29:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-223302@kernel.org> (raw)
In-Reply-To: <20261119-usbip-fix-v1-1-e6c04690115d@antmicro.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usbip: missing Fixes: trailer for USB_SPEED_FULL check in
  vhci_hub_control()
--

commit 327e8e6dfc01df8db046632ae205e6b5cd1a782a
Author: Zee Yudenko <zyudenko@internships.antmicro.com>

> usbip: Don't print port status error for full-speed devices
>
> When getting port status for USBIP, we only check for high- and low-speed
> settings, but not for the full-speed, which causes an 'vhci_device speed
> not set' error to be printed whenever a full-speed device is attached. A
> full-speed device is the default status, so we don't need to set any port
> status bits.
>
> Signed-off-by: Zee Yudenko <zyudenko@internships.antmicro.com>
> Signed-off-by: Jakub Jatczak <jjatczak@antmicro.com>

[Severity: Low]
This fixes the speed check in vhci_hub_control() where the default case
was changed to log an error without handling USB_SPEED_FULL.  Should this
include a Fixes tag?

  Fixes: 1c9de5bf4286 ("usbip: vhci-hcd: Add USB3 SuperSpeed support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-usbip-fix-v1-1-e6c04690115d@antmicro.com?part=1

      reply	other threads:[~2026-11-19 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:18 [PATCH] usbip: Don't print port status error for full-speed devices Jakub Jatczak via B4 Relay
2026-11-19 14:29 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223302@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=jjatczak@antmicro.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox