Linux USB
 help / color / mirror / Atom feed
* [PATCH] usbip: Don't print port status error for full-speed devices
@ 2026-11-19 14:18 Jakub Jatczak via B4 Relay
  2026-11-19 14:29 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jatczak via B4 Relay @ 2026-11-19 14:18 UTC (permalink / raw)
  To: Valentina Manea, Shuah Khan, Hongren Zheng, Greg Kroah-Hartman
  Cc: linux-usb, Zee Yudenko, Jakub Jatczak

From: Zee Yudenko <zyudenko@internships.antmicro.com>

When getting port status for USBIP, we only check for high- and low-speed
settings, but not for the full-speed, which causes an 'vhci_device speed
not set' error to be printed whenever a full-speed device is attached. A
full-speed device is the default status, so we don't need to set any port
status bits.

Signed-off-by: Zee Yudenko <zyudenko@internships.antmicro.com>
Signed-off-by: Jakub Jatczak <jjatczak@antmicro.com>
---
Patch authored by Zee Yudenko; I'm submitting it on their behalf.
Please direct feedback to me.
---
 drivers/usb/usbip/vhci_hcd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 39e8faf4c18c..936b98629921 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -480,6 +480,9 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
 					vhci_hcd->port_status[rhport] |=
 					      USB_PORT_STAT_HIGH_SPEED;
 					break;
+				case USB_SPEED_FULL:
+					/* this is the default, no flag needed */
+					break;
 				case USB_SPEED_LOW:
 					vhci_hcd->port_status[rhport] |=
 						USB_PORT_STAT_LOW_SPEED;

---
base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
change-id: 20261119-usbip-fix-3425997a5d70

Best regards,
--  
Jakub Jatczak <jjatczak@antmicro.com>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usbip: Don't print port status error for full-speed devices
  2026-11-19 14:18 [PATCH] usbip: Don't print port status error for full-speed devices Jakub Jatczak via B4 Relay
@ 2026-11-19 14:29 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-19 14:29 UTC (permalink / raw)
  To: Jakub Jatczak; +Cc: linux-usb

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usbip: missing Fixes: trailer for USB_SPEED_FULL check in
  vhci_hub_control()
--

commit 327e8e6dfc01df8db046632ae205e6b5cd1a782a
Author: Zee Yudenko <zyudenko@internships.antmicro.com>

> usbip: Don't print port status error for full-speed devices
>
> When getting port status for USBIP, we only check for high- and low-speed
> settings, but not for the full-speed, which causes an 'vhci_device speed
> not set' error to be printed whenever a full-speed device is attached. A
> full-speed device is the default status, so we don't need to set any port
> status bits.
>
> Signed-off-by: Zee Yudenko <zyudenko@internships.antmicro.com>
> Signed-off-by: Jakub Jatczak <jjatczak@antmicro.com>

[Severity: Low]
This fixes the speed check in vhci_hub_control() where the default case
was changed to log an error without handling USB_SPEED_FULL.  Should this
include a Fixes tag?

  Fixes: 1c9de5bf4286 ("usbip: vhci-hcd: Add USB3 SuperSpeed support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-usbip-fix-v1-1-e6c04690115d@antmicro.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-19 14:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 14:18 [PATCH] usbip: Don't print port status error for full-speed devices Jakub Jatczak via B4 Relay
2026-11-19 14:29 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox