public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] usb: xhci: Fix unassigned variable 'tmp_minor_revision' in xhci_add_in_port()
       [not found] ` <20250211115635.757-1-selvarasu.g@samsung.com>
@ 2025-02-11 11:56   ` Selvarasu Ganesan
  2025-02-11 11:56   ` [PATCH 2/2] usb: xhci: Fix unassigned variable 'bcdUSB' in xhci_create_usb3x_bos_desc() Selvarasu Ganesan
  1 sibling, 0 replies; 2+ messages in thread
From: Selvarasu Ganesan @ 2025-02-11 11:56 UTC (permalink / raw)
  To: mathias.nyman, gregkh, WeitaoWang-oc, Thinh.Nguyen, linux-usb,
	linux-kernel
  Cc: jh0801.jung, dh10.jung, naushad, akash.m5, h10.kim, eomji.oh,
	alim.akhtar, thiagu.r, muhammed.ali, pritam.sutar, cpgs,
	Selvarasu Ganesan, stable

Fix the following smatch error:
drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'

Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
Cc: stable@vger.kernel.org
Signed-off-by: Selvarasu Ganesan <selvarasu.g@samsung.com>
---
 drivers/usb/host/xhci-mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 92703efda1f7..8665893df894 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1980,7 +1980,7 @@ static void xhci_add_in_port(struct xhci_hcd *xhci, unsigned int num_ports,
 {
 	u32 temp, port_offset, port_count;
 	int i;
-	u8 major_revision, minor_revision, tmp_minor_revision;
+	u8 major_revision, minor_revision, tmp_minor_revision = 0;
 	struct xhci_hub *rhub;
 	struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
 	struct xhci_port_cap *port_cap;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 2/2] usb: xhci: Fix unassigned variable 'bcdUSB' in xhci_create_usb3x_bos_desc()
       [not found] ` <20250211115635.757-1-selvarasu.g@samsung.com>
  2025-02-11 11:56   ` [PATCH 1/2] usb: xhci: Fix unassigned variable 'tmp_minor_revision' in xhci_add_in_port() Selvarasu Ganesan
@ 2025-02-11 11:56   ` Selvarasu Ganesan
  1 sibling, 0 replies; 2+ messages in thread
From: Selvarasu Ganesan @ 2025-02-11 11:56 UTC (permalink / raw)
  To: mathias.nyman, gregkh, WeitaoWang-oc, Thinh.Nguyen, linux-usb,
	linux-kernel
  Cc: jh0801.jung, dh10.jung, naushad, akash.m5, h10.kim, eomji.oh,
	alim.akhtar, thiagu.r, muhammed.ali, pritam.sutar, cpgs,
	Selvarasu Ganesan, stable

Fix the following smatch error:
drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'

Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
Cc: stable@vger.kernel.org
Signed-off-by: Selvarasu Ganesan <selvarasu.g@samsung.com>
---
 drivers/usb/host/xhci-hub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 9693464c0520..5715a8bdda7f 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -39,7 +39,7 @@ static int xhci_create_usb3x_bos_desc(struct xhci_hcd *xhci, char *buf,
 	struct usb_ss_cap_descriptor	*ss_cap;
 	struct usb_ssp_cap_descriptor	*ssp_cap;
 	struct xhci_port_cap		*port_cap = NULL;
-	u16				bcdUSB;
+	u16				bcdUSB = 0;
 	u32				reg;
 	u32				min_rate = 0;
 	u8				min_ssid;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-12  1:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20250211115711epcas5p46b72b2670571d636c229d80378284ed9@epcas5p4.samsung.com>
     [not found] ` <20250211115635.757-1-selvarasu.g@samsung.com>
2025-02-11 11:56   ` [PATCH 1/2] usb: xhci: Fix unassigned variable 'tmp_minor_revision' in xhci_add_in_port() Selvarasu Ganesan
2025-02-11 11:56   ` [PATCH 2/2] usb: xhci: Fix unassigned variable 'bcdUSB' in xhci_create_usb3x_bos_desc() Selvarasu Ganesan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox