public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: "Hubert Wiśniewski" <hubert.wisniewski.25632@gmail.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ferry Toth" <ftoth@exalondelft.nl>,
	"Hardik Gajjar" <hgajjar@de.adit-jv.com>,
	"Kees Cook" <kees@kernel.org>,
	"Justin Stitt" <justinstitt@google.com>,
	"Richard Acayan" <mailingradian@gmail.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Ricardo B. Marliere" <ricardo@marliere.net>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3] usb: gadget: u_ether: Use __netif_rx() in rx_callback()
Date: Tue, 17 Sep 2024 15:56:33 +0200	[thread overview]
Message-ID: <155be9e56e650dd7f7baf1c7e193e1a3d85e7141.camel@gmail.com> (raw)

netif_rx() now disables bottom halves, which causes the USB gadget to be
unable to receive frames if the interface is not brought up quickly enough
after being created by the driver (a bug confirmed on AM3352 SoC).

Replacing netif_rx() with __netif_rx() restores the old behavior and fixes
the bug. This can be done since rx_callback() is called from the interrupt
context.

Fixes: baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
Cc: stable@vger.kernel.org
Signed-off-by: Hubert Wiśniewski <hubert.wisniewski.25632@gmail.com>
---
v2 -> v3: Added cc stable tag
v1 -> v2: Added Fixes tag and corrected Signed-off-by tag

 drivers/usb/gadget/function/u_ether.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 4bb0553da658..fd7e483b4a48 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -266,7 +266,7 @@ static void rx_complete(struct usb_ep *ep, struct usb_request *req)
 			/* no buffer copies needed, unless hardware can't
 			 * use skb buffers.
 			 */
-			status = netif_rx(skb2);
+			status = __netif_rx(skb2);
 next_frame:
 			skb2 = skb_dequeue(&dev->rx_frames);
 		}
-- 
2.30.2




             reply	other threads:[~2024-09-17 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-17 13:56 Hubert Wiśniewski [this message]
2024-09-17 14:36 ` [PATCH v3] usb: gadget: u_ether: Use __netif_rx() in rx_callback() Sebastian Andrzej Siewior
2024-09-26 19:39   ` Hubert Wiśniewski
2024-09-27 13:33     ` Hubert Wiśniewski
2024-09-27 14:12       ` Sebastian Andrzej Siewior
2024-10-01 14:06         ` Hubert Wiśniewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155be9e56e650dd7f7baf1c7e193e1a3d85e7141.camel@gmail.com \
    --to=hubert.wisniewski.25632@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ftoth@exalondelft.nl \
    --cc=gregkh@linuxfoundation.org \
    --cc=hgajjar@de.adit-jv.com \
    --cc=justinstitt@google.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mailingradian@gmail.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=ricardo@marliere.net \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox