From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Hubert Wiśniewski" <hubert.wisniewski.25632@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ferry Toth" <ftoth@exalondelft.nl>,
"Hardik Gajjar" <hgajjar@de.adit-jv.com>,
"Kees Cook" <kees@kernel.org>,
"Justin Stitt" <justinstitt@google.com>,
"Richard Acayan" <mailingradian@gmail.com>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"Ricardo B. Marliere" <ricardo@marliere.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: gadget: u_ether: Use __netif_rx() in rx_callback()
Date: Tue, 17 Sep 2024 16:36:18 +0200 [thread overview]
Message-ID: <20240917143618.jPgAwF3M@linutronix.de> (raw)
In-Reply-To: <155be9e56e650dd7f7baf1c7e193e1a3d85e7141.camel@gmail.com>
On 2024-09-17 15:56:33 [+0200], Hubert Wiśniewski wrote:
> netif_rx() now disables bottom halves, which causes the USB gadget to be
> unable to receive frames if the interface is not brought up quickly enough
> after being created by the driver (a bug confirmed on AM3352 SoC).
>
> Replacing netif_rx() with __netif_rx() restores the old behavior and fixes
> the bug. This can be done since rx_callback() is called from the interrupt
> context.
>
> Fixes: baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hubert Wiśniewski <hubert.wisniewski.25632@gmail.com>
Now that I see v3, my v2 question stands.
This supposed only to disable BH if invoked from from non-interrupt.
hardirq and softirq should be good. A backtrace would be nice and further
explanation how this becomes a problem. Also lockdep should complain at
some point.
Sebastian
next prev parent reply other threads:[~2024-09-17 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 13:56 [PATCH v3] usb: gadget: u_ether: Use __netif_rx() in rx_callback() Hubert Wiśniewski
2024-09-17 14:36 ` Sebastian Andrzej Siewior [this message]
2024-09-26 19:39 ` Hubert Wiśniewski
2024-09-27 13:33 ` Hubert Wiśniewski
2024-09-27 14:12 ` Sebastian Andrzej Siewior
2024-10-01 14:06 ` Hubert Wiśniewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917143618.jPgAwF3M@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ftoth@exalondelft.nl \
--cc=gregkh@linuxfoundation.org \
--cc=hgajjar@de.adit-jv.com \
--cc=hubert.wisniewski.25632@gmail.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=quic_jjohnson@quicinc.com \
--cc=ricardo@marliere.net \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox