From: Wang Yufen <wangyufen@huawei.com>
To: <gregkh@linuxfoundation.org>, <linus.walleij@linaro.org>,
<mailhol.vincent@wanadoo.fr>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wangyufen@huawei.com>
Subject: [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe()
Date: Tue, 29 Nov 2022 14:43:52 +0800 [thread overview]
Message-ID: <1669704232-40228-1-git-send-email-wangyufen@huawei.com> (raw)
Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
instead of 0.
Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/usb/host/fhci-hcd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 95a4446..c8a1b98 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
NULL, i, GPIOD_OUT_LOW);
if (IS_ERR(fhci->gpiods[i])) {
- dev_err(dev, "incorrect GPIO%d: %ld\n",
- i, PTR_ERR(fhci->gpiods[i]));
+ ret = PTR_ERR(fhci->gpiods[i]);
+ dev_err(dev, "incorrect GPIO%d: %d\n",
+ i, ret);
goto err_gpios;
}
if (!fhci->gpiods[i]) {
--
1.8.3.1
next reply other threads:[~2022-11-29 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 6:43 Wang Yufen [this message]
2022-11-29 7:03 ` [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe() Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1669704232-40228-1-git-send-email-wangyufen@huawei.com \
--to=wangyufen@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox