* [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe()
@ 2022-11-29 6:43 Wang Yufen
2022-11-29 7:03 ` Vincent MAILHOL
0 siblings, 1 reply; 2+ messages in thread
From: Wang Yufen @ 2022-11-29 6:43 UTC (permalink / raw)
To: gregkh, linus.walleij, mailhol.vincent; +Cc: linux-usb, linux-kernel, wangyufen
Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
instead of 0.
Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/usb/host/fhci-hcd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 95a4446..c8a1b98 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
NULL, i, GPIOD_OUT_LOW);
if (IS_ERR(fhci->gpiods[i])) {
- dev_err(dev, "incorrect GPIO%d: %ld\n",
- i, PTR_ERR(fhci->gpiods[i]));
+ ret = PTR_ERR(fhci->gpiods[i]);
+ dev_err(dev, "incorrect GPIO%d: %d\n",
+ i, ret);
goto err_gpios;
}
if (!fhci->gpiods[i]) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe()
2022-11-29 6:43 [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe() Wang Yufen
@ 2022-11-29 7:03 ` Vincent MAILHOL
0 siblings, 0 replies; 2+ messages in thread
From: Vincent MAILHOL @ 2022-11-29 7:03 UTC (permalink / raw)
To: Wang Yufen; +Cc: gregkh, linus.walleij, linux-usb, linux-kernel
On Tue. 29 Nov. 2022 at 15:43, Wang Yufen <wangyufen@huawei.com> wrote:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> drivers/usb/host/fhci-hcd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..c8a1b98 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
> NULL, i, GPIOD_OUT_LOW);
>
> if (IS_ERR(fhci->gpiods[i])) {
> - dev_err(dev, "incorrect GPIO%d: %ld\n",
> - i, PTR_ERR(fhci->gpiods[i]));
> + ret = PTR_ERR(fhci->gpiods[i]);
> + dev_err(dev, "incorrect GPIO%d: %d\n",
> + i, ret);
Nitpick: you do not need a new line. It fits the 80 characters limit very well.
Aside of that:
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> goto err_gpios;
> }
> if (!fhci->gpiods[i]) {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-29 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-29 6:43 [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe() Wang Yufen
2022-11-29 7:03 ` Vincent MAILHOL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox