Linux USB
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, quic_wcheng@quicinc.com,
	linux-usb@vger.kernel.org, konrad.dybcio@linaro.org,
	devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-phy@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org,
	andersson@kernel.org, kishon@kernel.org, kernel@quicinc.com,
	conor+dt@kernel.org, agross@kernel.org, abel.vesa@linaro.org,
	vkoul@kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: phy: Add qcom,sdx75-qmp-usb3-uni schema file
Date: Tue, 05 Sep 2023 12:48:50 -0500	[thread overview]
Message-ID: <169393613081.3654258.4653148258731976775.robh@kernel.org> (raw)
In-Reply-To: <1693889028-6485-3-git-send-email-quic_rohiagar@quicinc.com>


On Tue, 05 Sep 2023 10:13:45 +0530, Rohit Agarwal wrote:
> Add a dt-binding schema for SDX75 SoC.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  .../bindings/phy/qcom,sdx75-qmp-usb3-uni-phy.yaml  | 106 +++++++++++++++++++++
>  1 file changed, 106 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/qcom,sdx75-qmp-usb3-uni-phy.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/qcom,sdx75-qmp-usb3-uni-phy.example.dts:18:18: fatal error: dt-bindings/clock/qcom,gcc-sdx75.h: No such file or directory
   18 |         #include <dt-bindings/clock/qcom,gcc-sdx75.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/phy/qcom,sdx75-qmp-usb3-uni-phy.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1693889028-6485-3-git-send-email-quic_rohiagar@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2023-09-05 18:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05  4:43 [PATCH 0/5] Add USB Support on Qualcomm's SDX75 Platform Rohit Agarwal
2023-09-05  4:43 ` [PATCH 1/5] dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75 Rohit Agarwal
2023-09-05  6:47   ` Krzysztof Kozlowski
2023-09-05  4:43 ` [PATCH 2/5] dt-bindings: phy: Add qcom,sdx75-qmp-usb3-uni schema file Rohit Agarwal
2023-09-05  6:49   ` Krzysztof Kozlowski
2023-09-05  7:08     ` Rohit Agarwal
2023-09-05  7:20       ` Krzysztof Kozlowski
2023-09-05  7:27         ` Rohit Agarwal
2023-09-05 17:48   ` Rob Herring [this message]
2023-09-05  4:43 ` [PATCH 3/5] dt-bindings: usb: dwc3: Add missing SDX65 compatible Rohit Agarwal
2023-09-05  6:49   ` Krzysztof Kozlowski
2023-09-05  6:51     ` Krzysztof Kozlowski
2023-09-05  7:10       ` Rohit Agarwal
2023-09-05  4:43 ` [PATCH 4/5] dt-bindings: usb: dwc3: Add SDX75 compatible Rohit Agarwal
2023-09-05  6:54   ` Krzysztof Kozlowski
2023-09-05  4:43 ` [PATCH 5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support Rohit Agarwal
2023-09-05  6:53   ` Krzysztof Kozlowski
2023-09-05  7:12     ` Rohit Agarwal
2023-09-05 20:30   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169393613081.3654258.4653148258731976775.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@quicinc.com \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_rohiagar@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox