From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
abel.vesa@linaro.org, quic_wcheng@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH 5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support
Date: Tue, 5 Sep 2023 08:53:41 +0200 [thread overview]
Message-ID: <f49b9075-93b7-6f4a-ef80-543bd5b497e2@linaro.org> (raw)
In-Reply-To: <1693889028-6485-6-git-send-email-quic_rohiagar@quicinc.com>
On 05/09/2023 06:43, Rohit Agarwal wrote:
> Add support for USB3 QMP PHY found in SDX75 platform.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>
> +static const struct qmp_phy_cfg sdx75_usb3_uniphy_cfg = {
> + .lanes = 1,
> + .offsets = &qmp_usb_offsets_v5,
> +
> + .serdes_tbl = sdx75_usb3_uniphy_serdes_tbl,
> + .serdes_tbl_num = ARRAY_SIZE(sdx75_usb3_uniphy_serdes_tbl),
> + .tx_tbl = sdx75_usb3_uniphy_tx_tbl,
> + .tx_tbl_num = ARRAY_SIZE(sdx75_usb3_uniphy_tx_tbl),
> + .rx_tbl = sdx75_usb3_uniphy_rx_tbl,
> + .rx_tbl_num = ARRAY_SIZE(sdx75_usb3_uniphy_rx_tbl),
> + .pcs_tbl = sdx75_usb3_uniphy_pcs_tbl,
> + .pcs_tbl_num = ARRAY_SIZE(sdx75_usb3_uniphy_pcs_tbl),
> + .pcs_usb_tbl = sdx75_usb3_uniphy_pcs_usb_tbl,
> + .pcs_usb_tbl_num = ARRAY_SIZE(sdx75_usb3_uniphy_pcs_usb_tbl),
> + .clk_list = qmp_v4_sdx55_usbphy_clk_l,
> + .num_clks = ARRAY_SIZE(qmp_v4_sdx55_usbphy_clk_l),
> + .reset_list = msm8996_usb3phy_reset_l,
> + .num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l),
> + .vreg_list = qmp_phy_vreg_l,
> + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
> + .regs = qmp_v5_usb3phy_regs_layout,
> + .pcs_usb_offset = 0x1000,
> +
> + .has_pwrdn_delay = true,
> +
Stray blank line
> +};
> +
> static const struct qmp_phy_cfg sm8350_usb3phy_cfg = {
> .lanes = 2,
>
> @@ -1985,6 +2141,7 @@ static int qmp_usb_init(struct phy *phy)
> void __iomem *dp_com = qmp->dp_com;
> int ret;
>
> +
No need for this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-05 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 4:43 [PATCH 0/5] Add USB Support on Qualcomm's SDX75 Platform Rohit Agarwal
2023-09-05 4:43 ` [PATCH 1/5] dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75 Rohit Agarwal
2023-09-05 6:47 ` Krzysztof Kozlowski
2023-09-05 4:43 ` [PATCH 2/5] dt-bindings: phy: Add qcom,sdx75-qmp-usb3-uni schema file Rohit Agarwal
2023-09-05 6:49 ` Krzysztof Kozlowski
2023-09-05 7:08 ` Rohit Agarwal
2023-09-05 7:20 ` Krzysztof Kozlowski
2023-09-05 7:27 ` Rohit Agarwal
2023-09-05 17:48 ` Rob Herring
2023-09-05 4:43 ` [PATCH 3/5] dt-bindings: usb: dwc3: Add missing SDX65 compatible Rohit Agarwal
2023-09-05 6:49 ` Krzysztof Kozlowski
2023-09-05 6:51 ` Krzysztof Kozlowski
2023-09-05 7:10 ` Rohit Agarwal
2023-09-05 4:43 ` [PATCH 4/5] dt-bindings: usb: dwc3: Add SDX75 compatible Rohit Agarwal
2023-09-05 6:54 ` Krzysztof Kozlowski
2023-09-05 4:43 ` [PATCH 5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support Rohit Agarwal
2023-09-05 6:53 ` Krzysztof Kozlowski [this message]
2023-09-05 7:12 ` Rohit Agarwal
2023-09-05 20:30 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f49b9075-93b7-6f4a-ef80-543bd5b497e2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@quicinc.com \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox