From: Joe Perches <joe@perches.com>
To: Gabriel Viso Carrera <gabriel@gvisoc.com>, andreas.noever@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment coding style issues
Date: Sat, 25 Jun 2022 02:37:54 -0700 [thread overview]
Message-ID: <1a35d3bdf6adde4f21e7c1401f3a2aba64367eb0.camel@perches.com> (raw)
In-Reply-To: <20220625084913.603556-4-gabriel@gvisoc.com>
On Sat, 2022-06-25 at 18:49 +1000, Gabriel Viso Carrera wrote:
> Fixed a couple of comment aligment & formatting coding style issues.
trivia:
> diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
[]
> @@ -402,11 +403,11 @@ static bool tb_ctl_handle_event(struct tb_ctl *ctl, enum tb_cfg_pkg_type type,
> static void tb_ctl_rx_submit(struct ctl_pkg *pkg)
> {
> tb_ring_rx(pkg->ctl->rx, &pkg->frame); /*
> - * We ignore failures during stop.
> - * All rx packets are referenced
> - * from ctl->rx_packets, so we do
> - * not loose them.
> - */
> + * We ignore failures during stop.
> + * All rx packets are referenced
> + * from ctl->rx_packets, so we do
> + * not loose them.
> + */
I'd indent this only 1 level and put it before the call
(and fix the loose/lose typo)
{
/* We ignore failures during stop.
* All rx packets are referenced from ctl->rx_packets,
* so we do not lose them.
*/
tb_ring_rx(pkg->ctl->rx, &pkg->frame);
}
next prev parent reply other threads:[~2022-06-25 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 8:49 staging: Thunderbolt: ctl.c style coding issues Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 1/3] staging: Thunderbolt: ctl.c: Fixed 2 literal " Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 2/3] staging: Thunderbolt: ctl.c: Fixed blank line coding style issues Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment " Gabriel Viso Carrera
2022-06-25 9:37 ` Joe Perches [this message]
2022-06-29 6:54 ` Gabriel Viso Carrera
2022-06-29 7:02 ` Greg KH
2022-06-29 7:47 ` Gabriel Viso Carrera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a35d3bdf6adde4f21e7c1401f3a2aba64367eb0.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.noever@gmail.com \
--cc=gabriel@gvisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox