From: Gabriel Viso Carrera <gabriel@gvisoc.com>
To: andreas.noever@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Gabriel Viso Carrera <gabriel@gvisoc.com>
Subject: [PATCH 1/3] staging: Thunderbolt: ctl.c: Fixed 2 literal style coding issues
Date: Sat, 25 Jun 2022 18:49:11 +1000 [thread overview]
Message-ID: <20220625084913.603556-2-gabriel@gvisoc.com> (raw)
In-Reply-To: <20220625084913.603556-1-gabriel@gvisoc.com>
In lines 1028 and 1054, there were WARN calls with hardcoded literal
function name. Replaced with the recommended %s and __func__.
Signed-off-by: Gabriel Viso Carrera <gabriel@gvisoc.com>
---
drivers/thunderbolt/ctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index e92c658dba1c..4b841fbb3628 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -1025,7 +1025,7 @@ int tb_cfg_read(struct tb_ctl *ctl, void *buffer, u64 route, u32 port,
break;
default:
- WARN(1, "tb_cfg_read: %d\n", res.err);
+ WARN(1, "%s: %d\n", __func__, res.err);
break;
}
return res.err;
@@ -1051,7 +1051,7 @@ int tb_cfg_write(struct tb_ctl *ctl, const void *buffer, u64 route, u32 port,
break;
default:
- WARN(1, "tb_cfg_write: %d\n", res.err);
+ WARN(1, "%s: %d\n", __func__, res.err);
break;
}
return res.err;
--
2.36.1
next prev parent reply other threads:[~2022-06-25 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 8:49 staging: Thunderbolt: ctl.c style coding issues Gabriel Viso Carrera
2022-06-25 8:49 ` Gabriel Viso Carrera [this message]
2022-06-25 8:49 ` [PATCH 2/3] staging: Thunderbolt: ctl.c: Fixed blank line coding style issues Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment " Gabriel Viso Carrera
2022-06-25 9:37 ` Joe Perches
2022-06-29 6:54 ` Gabriel Viso Carrera
2022-06-29 7:02 ` Greg KH
2022-06-29 7:47 ` Gabriel Viso Carrera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220625084913.603556-2-gabriel@gvisoc.com \
--to=gabriel@gvisoc.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox