From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Jan Schmidt <jan@centricular.com>
Cc: p.zabel@pengutronix.de, linux-usb@vger.kernel.org
Subject: Re: [RFT PATCH] xhci: Prevent device initiated U1/U2 link pm if exit latency is too long
Date: Wed, 18 Sep 2019 15:46:01 +0300 [thread overview]
Message-ID: <1efe04f6-d2b5-78c9-38eb-5fe093a7e7b8@linux.intel.com> (raw)
In-Reply-To: <8a372d28-a011-4060-ac12-2291fdc33a4d@centricular.com>
On 17.9.2019 18.56, Jan Schmidt wrote:
>
>
> On 18/9/19 12:53 am, Mathias Nyman wrote:
>> If host/hub initiated link pm is prevented by a driver flag we still must
>> ensure that periodic endpoints have longer service intervals than link pm
>> exit latency before allowing device initiated link pm.
>>
>> Fix this by continue walking and checking endpoint service interval if
>> xhci_get_timeout_no_hub_lpm() returns anything else than USB3_LPM_DISABLED
>>
>> While at it fix the split line error message
>>
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>
> I tested by forcing the driver->disable_hub_initiated_lpm check and
> confirm a) Other USB devices still work as I expect them to b) without
> this patch, I'm back to only 1 working Oculus Rift Sensor. With it, I
> can capture 3 simultaneously.
>
> Tested-by: Jan Schmidt <jan@centricular.com>
>
Great, thanks, I'll queue up that patch as well with your Tested-by tag
-Mathias
prev parent reply other threads:[~2019-09-18 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 14:49 [PATCH] xhci: Check all endpoints for LPM timeout Jan Schmidt
2019-09-12 15:14 ` Philipp Zabel
2019-09-13 12:58 ` Mathias Nyman
2019-09-13 13:46 ` Jan Schmidt
2019-09-17 14:53 ` [RFT PATCH] xhci: Prevent device initiated U1/U2 link pm if exit latency is too long Mathias Nyman
2019-09-17 15:56 ` Jan Schmidt
2019-09-18 12:46 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efe04f6-d2b5-78c9-38eb-5fe093a7e7b8@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=jan@centricular.com \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox