Linux USB
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
	linux-usb@vger.kernel.org,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Johan Hovold <johan@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()
Date: Wed, 6 Dec 2017 16:18:34 +0300	[thread overview]
Message-ID: <20171206131834.qxlswkis72wmzed7@mwanda> (raw)

On Wed, Dec 06, 2017 at 01:12:32PM +0100, Julia Lawall wrote:
> 
> 
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> 
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Wed, 6 Dec 2017 13:03:21 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  drivers/usb/misc/emi26.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c
> > index 24d841850e05..654e93857d65 100644
> > --- a/drivers/usb/misc/emi26.c
> > +++ b/drivers/usb/misc/emi26.c
> > @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
> >  	int result;
> >  	unsigned char *buffer =  kmemdup(data, length, GFP_KERNEL);
> >
> > -	if (!buffer) {
> > -		dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
> 
> I guess the length information would not be so easy to find in the
> backtrace.
> 

I think it prints the "order" but not the exact size.

regards,
dan carpeneter
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2017-12-06 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 13:18 Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-12-06 13:25 USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() SF Markus Elfring
2017-12-06 12:12 Julia Lawall
2017-12-06 12:06 SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206131834.qxlswkis72wmzed7@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=elfring@users.sourceforge.net \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox