From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-usb@vger.kernel.org,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()
Date: Wed, 6 Dec 2017 13:06:32 +0100 [thread overview]
Message-ID: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 6 Dec 2017 13:03:21 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/usb/misc/emi26.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c
index 24d841850e05..654e93857d65 100644
--- a/drivers/usb/misc/emi26.c
+++ b/drivers/usb/misc/emi26.c
@@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
int result;
unsigned char *buffer = kmemdup(data, length, GFP_KERNEL);
- if (!buffer) {
- dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
+ if (!buffer)
return -ENOMEM;
- }
+
/* Note: usb_control_msg returns negative value on error or length of the
* data that was written! */
result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300);
next reply other threads:[~2017-12-06 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 12:06 SF Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-06 12:12 USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() Julia Lawall
2017-12-06 13:18 Dan Carpenter
2017-12-06 13:25 SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox