From: Philip Langdale <philipl@overt.org>
To: linux-usb@vger.kernel.org
Cc: Philip Langdale <philipl@overt.org>
Subject: xhci-pci: don't enable runtime PM for Alpine Ridge on Maximus VIII Impact
Date: Sun, 30 Dec 2018 08:34:25 -0800 [thread overview]
Message-ID: <20181230163425.17649-1-philipl@overt.org> (raw)
This fixes a regression since: 2815ef7fe4d43072b9eda448d04fbc184f2aa513
This motherboard is a strange beast, with an Alpine Ridge thunderbolt
controller configured to only do USB with no actual thunderbolt
capabilities (Apparently due to the wiring not being thunderbolt
compliant).
When runtime PM is enabled in this case, plugging in a USB device results
in nothing being detected. Everything works fine when runtime PM is not
enabled.
Signed-off-by: Philip Langdale <philipl@overt.org>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=202095
---
drivers/usb/host/xhci-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index a9ec7051f286..147ae893f055 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -211,7 +211,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
pdev->device == PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_XHCI ||
pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_XHCI ||
pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_XHCI ||
- pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_DD_XHCI))
+ pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_DD_XHCI) &&
+ pdev->subsystem_vendor != 0x2222 &&
+ pdev->subsystem_device != 0x1111)
xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
next reply other threads:[~2018-12-30 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 16:34 Philip Langdale [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-02 11:23 xhci-pci: don't enable runtime PM for Alpine Ridge on Maximus VIII Impact Mathias Nyman
2019-01-03 4:00 Philip Langdale
2019-01-03 8:17 Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230163425.17649-1-philipl@overt.org \
--to=philipl@overt.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox