From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Philip Langdale <philipl@overt.org>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>, linux-usb@vger.kernel.org
Subject: xhci-pci: don't enable runtime PM for Alpine Ridge on Maximus VIII Impact
Date: Thu, 3 Jan 2019 10:17:39 +0200 [thread overview]
Message-ID: <20190103081739.GK2469@lahna.fi.intel.com> (raw)
On Wed, Jan 02, 2019 at 08:00:41PM -0800, Philip Langdale wrote:
> > 0e157e5 PCI/PME: Implement runtime PM callbacks
>
> Yes, if I revert this change it also works. And I am reminded that when
> I tested the hash from the usb branch that was merged for 4.20, but on
> the original branch, it didn't fail either. So I guess it's the
> interaction between the two changes that causes the breakage.
Right, if only the xHCI is runtime suspended but not the PCIe switch it
is part of, things should work. We definitely want to make sure the
whole hierarhcy goes into D3cold whenever possible (to save energy) so
xHCI runtime PM should be enabled. The above commit tries to fix another
issue but it seems it is not correct and causes issues like what you are
seeing and another one reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=202103
I'm currently investigating it.
next reply other threads:[~2019-01-03 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 8:17 Mika Westerberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-03 4:00 xhci-pci: don't enable runtime PM for Alpine Ridge on Maximus VIII Impact Philip Langdale
2019-01-02 11:23 Mathias Nyman
2018-12-30 16:34 Philip Langdale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103081739.GK2469@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox