From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: USB: serial: io_edgeport: fix up switch fall-through comments
Date: Fri, 3 May 2019 08:09:08 +0200 [thread overview]
Message-ID: <20190503060908.GY26546@localhost> (raw)
On Thu, May 02, 2019 at 07:35:15PM +0200, Greg Kroah-Hartman wrote:
> Gustavo has been working to fix up all of the switch statements that
> "fall through" such that we can eventually turn on
> -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a
> bit "messy" with the parsing logic of a data packet. Clean that logic
> up a bit by unindenting one level of the logic, and properly label
> /* Fall through */ to make gcc happy.
>
> Reported-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Now applied, thanks.
Gustavo, how many of these warnings are there left in the kernel now
that the last one in USB is gone? :)
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments
Date: Fri, 3 May 2019 08:09:08 +0200 [thread overview]
Message-ID: <20190503060908.GY26546@localhost> (raw)
Message-ID: <20190503060908.gL3yEle7NV9gzeriCAHGob-WUny6v3qlVWGzVmMAWcQ@z> (raw)
In-Reply-To: <20190502173515.GA13801@kroah.com>
On Thu, May 02, 2019 at 07:35:15PM +0200, Greg Kroah-Hartman wrote:
> Gustavo has been working to fix up all of the switch statements that
> "fall through" such that we can eventually turn on
> -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a
> bit "messy" with the parsing logic of a data packet. Clean that logic
> up a bit by unindenting one level of the logic, and properly label
> /* Fall through */ to make gcc happy.
>
> Reported-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Now applied, thanks.
Gustavo, how many of these warnings are there left in the kernel now
that the last one in USB is gone? :)
Johan
next prev reply other threads:[~2019-05-03 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 17:35 USB: serial: io_edgeport: fix up switch fall-through comments Greg Kroah-Hartman
2019-05-02 17:35 ` [PATCH] " Greg Kroah-Hartman
2019-05-02 17:45 ` Gustavo A. R. Silva
2019-05-02 17:45 ` [PATCH] " Gustavo A. R. Silva
2019-05-03 6:09 ` Johan Hovold [this message]
2019-05-03 6:09 ` Johan Hovold
2019-05-03 14:00 ` Gustavo A. R. Silva
2019-05-03 14:00 ` [PATCH] " Gustavo A. R. Silva
2019-05-03 15:46 ` Johan Hovold
2019-05-03 15:46 ` [PATCH] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503060908.GY26546@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox