From: Pete Zaitcev <zaitcev@redhat.com>
To: "Tomasz Moń" <desowin@gmail.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] usbmon: Report device address assigned to USB device
Date: Mon, 6 Jan 2020 17:09:44 -0600 [thread overview]
Message-ID: <20200106170944.03a97034@suzdal.zaitcev.lan> (raw)
In-Reply-To: <20200106093724.22947-1-desowin@gmail.com>
On Mon, 6 Jan 2020 10:37:17 +0100
Tomasz Moń <desowin@gmail.com> wrote:
> Make USB device addresses match while sniffing USB communication
> with usbmon and hardware USB sniffer (OpenVizsla) at the same time.
> On xHCI root hubs the address is assigned by hardware and can be
> different than devnum.
> - unsigned char devnum; /* Device address */
> + unsigned char devaddr; /* Device address */
I think it's fine, the name of the field is not exported by a header
anyway, so there's no impact.
Acked-by: Pete Zaitcev <zaitcev@redhat.com>
-- Pete
next prev parent reply other threads:[~2020-01-06 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 9:37 [PATCH] usbmon: Report device address assigned to USB device Tomasz Moń
2020-01-06 23:09 ` Pete Zaitcev [this message]
2020-01-08 15:55 ` Greg Kroah-Hartman
2020-01-11 23:52 ` Pete Zaitcev
2020-01-13 15:05 ` Alan Stern
2020-01-14 21:06 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106170944.03a97034@suzdal.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=corbet@lwn.net \
--cc=desowin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox