From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
USB list <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"pawell@cadence.com" <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>, Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH v2 1/1] usb: cdns3: add NXP imx8qm glue layer
Date: Mon, 13 Jan 2020 11:13:38 +0100 [thread overview]
Message-ID: <20200113101338.GA2116805@kroah.com> (raw)
In-Reply-To: <20200113092525.GL17599@b29397-desktop>
On Mon, Jan 13, 2020 at 09:25:28AM +0000, Peter Chen wrote:
> On 20-01-11 17:56:06, Fabio Estevam wrote:
> > Hi Peter,
> >
> > On Thu, Jan 9, 2020 at 7:55 AM Peter Chen <peter.chen@nxp.com> wrote:
> >
> > > +static const struct of_device_id cdns_imx_of_match[] = {
> > > + { .compatible = "fsl,imx8qm-usb3", },
> >
> > Please also send a separate patch for documenting this compatible string.
>
> I had wanted to add it, but the working version is based on some
> other basic dts patches, eg clock changes, which has still not
> in mainline, so some properties in the example at this dt binding
> file may not be found at mainline kernel, is it ok?
No, sorry, that does not work, please get the dts patch in as well.
thanks,
greg k-h
prev parent reply other threads:[~2020-01-13 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 9:35 [PATCH v2 1/1] usb: cdns3: add NXP imx8qm glue layer Peter Chen
2020-01-09 12:20 ` Roger Quadros
2020-01-13 9:20 ` Peter Chen
2020-01-11 19:25 ` Greg KH
2020-01-13 9:20 ` Peter Chen
2020-01-11 20:56 ` Fabio Estevam
2020-01-13 9:25 ` Peter Chen
2020-01-13 10:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113101338.GA2116805@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox