From: Greg KH <gregkh@linuxfoundation.org>
To: "Diego Elio Pettenò" <flameeyes@flameeyes.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
Paolo Abeni <paolo.abeni@gmail.com>,
Kris Katterjohn <katterjohn@gmail.com>,
linux-usb@vger.kernel.org
Subject: Re: usbmon structures headers?
Date: Sun, 5 Jul 2020 16:24:03 +0200 [thread overview]
Message-ID: <20200705142403.GA1629177@kroah.com> (raw)
In-Reply-To: <74a26b91-489f-4c04-a53e-8930a9df9bd6@www.fastmail.com>
On Sat, Jul 04, 2020 at 10:46:09PM +0100, Diego Elio Pettenò wrote:
> (Updating Paolo's email, that is out of date in both sources.)
>
> On Sat, Jul 4, 2020, at 22:43, Diego Elio Pettenò wrote:
> > Hi folks,
> >
> > I'm trying to write a quick implementation of usbmon capture in Cython,
> > for an Apache-2.0 licensed project[1].
> >
> > As I followed the documentation[2], I realised that the definition of
> > ioctl constants and structures for usbmon are not exposed in headers at
> > all, only in the sources[3]. This makes it… a bit of a problem, because
> > I'm not sure if mimicking the structures in Cython falls into the
> > syscall exception at that point.
> >
> > Interesting enough, libpcap appears to define the same values, but
> > apply an MIT license to them[4], so I could copy them from there, but I
> > thought I would at least check first, if this should be exposed in the
> > first place.
> >
> > Please advise!
> >
> > [1]: https://github.com/Flameeyes/usbmon-tools
> > [2]: https://www.kernel.org/doc/Documentation/usb/usbmon.txt
> > [3]: https://github.com/torvalds/linux/blob/master/drivers/usb/mon/mon_bin.c
> > [4]: https://github.com/the-tcpdump-group/libpcap/blob/master/pcap-usb-linux.c
Yeah, we really should put those structures in include/uapi/ with the
proper license. Care to make a patch for it?
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-05 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 21:43 usbmon structures headers? Diego Elio Pettenò
2020-07-04 21:46 ` Diego Elio Pettenò
2020-07-05 14:24 ` Greg KH [this message]
2020-07-05 14:28 ` Diego Elio Pettenò
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705142403.GA1629177@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=flameeyes@flameeyes.com \
--cc=katterjohn@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=paolo.abeni@gmail.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox