usbmon structures headers?

usbmon structures headers?

[Diego Elio Pettenò]

Hi folks,

I'm trying to write a quick implementation of usbmon capture in Cython, for an Apache-2.0 licensed project[1].

As I followed the documentation[2], I realised that the definition of ioctl constants and structures for usbmon are not exposed in headers at all, only in the sources[3]. This makes it… a bit of a problem, because I'm not sure if mimicking the structures in Cython falls into the syscall exception at that point.

Interesting enough, libpcap appears to define the same values, but apply an MIT license to them[4], so I could copy them from there, but I thought I would at least check first, if this should be exposed in the first place.

Please advise!

[1]: https://github.com/Flameeyes/usbmon-tools
[2]: https://www.kernel.org/doc/Documentation/usb/usbmon.txt
[3]: https://github.com/torvalds/linux/blob/master/drivers/usb/mon/mon_bin.c
[4]: https://github.com/the-tcpdump-group/libpcap/blob/master/pcap-usb-linux.c

-- 
Flameeyes

Re: usbmon structures headers?

[Diego Elio Pettenò]

(Updating Paolo's email, that is out of date in both sources.)

On Sat, Jul 4, 2020, at 22:43, Diego Elio Pettenò wrote:
> Hi folks,
> 
> I'm trying to write a quick implementation of usbmon capture in Cython, 
> for an Apache-2.0 licensed project[1].
> 
> As I followed the documentation[2], I realised that the definition of 
> ioctl constants and structures for usbmon are not exposed in headers at 
> all, only in the sources[3]. This makes it… a bit of a problem, because 
> I'm not sure if mimicking the structures in Cython falls into the 
> syscall exception at that point.
> 
> Interesting enough, libpcap appears to define the same values, but 
> apply an MIT license to them[4], so I could copy them from there, but I 
> thought I would at least check first, if this should be exposed in the 
> first place.
> 
> Please advise!
> 
> [1]: https://github.com/Flameeyes/usbmon-tools
> [2]: https://www.kernel.org/doc/Documentation/usb/usbmon.txt
> [3]: https://github.com/torvalds/linux/blob/master/drivers/usb/mon/mon_bin.c
> [4]: https://github.com/the-tcpdump-group/libpcap/blob/master/pcap-usb-linux.c
> 
> -- 
> Flameeyes
>

Re: usbmon structures headers?

[Greg KH]

On Sat, Jul 04, 2020 at 10:46:09PM +0100, Diego Elio Pettenò wrote:
> (Updating Paolo's email, that is out of date in both sources.)
> 
> On Sat, Jul 4, 2020, at 22:43, Diego Elio Pettenò wrote:
> > Hi folks,
> > 
> > I'm trying to write a quick implementation of usbmon capture in Cython, 
> > for an Apache-2.0 licensed project[1].
> > 
> > As I followed the documentation[2], I realised that the definition of 
> > ioctl constants and structures for usbmon are not exposed in headers at 
> > all, only in the sources[3]. This makes it… a bit of a problem, because 
> > I'm not sure if mimicking the structures in Cython falls into the 
> > syscall exception at that point.
> > 
> > Interesting enough, libpcap appears to define the same values, but 
> > apply an MIT license to them[4], so I could copy them from there, but I 
> > thought I would at least check first, if this should be exposed in the 
> > first place.
> > 
> > Please advise!
> > 
> > [1]: https://github.com/Flameeyes/usbmon-tools
> > [2]: https://www.kernel.org/doc/Documentation/usb/usbmon.txt
> > [3]: https://github.com/torvalds/linux/blob/master/drivers/usb/mon/mon_bin.c
> > [4]: https://github.com/the-tcpdump-group/libpcap/blob/master/pcap-usb-linux.c

Yeah, we really should put those structures in include/uapi/ with the
proper license.  Care to make a patch for it?

thanks,

greg k-h

Re: usbmon structures headers?

[Diego Elio Pettenò]

Yep sounds good (at least I'll try to do it right.)

On Sun, Jul 5, 2020, at 15:24, Greg KH wrote:
> On Sat, Jul 04, 2020 at 10:46:09PM +0100, Diego Elio Pettenò wrote:
> > (Updating Paolo's email, that is out of date in both sources.)
> > 
> > On Sat, Jul 4, 2020, at 22:43, Diego Elio Pettenò wrote:
> > > Hi folks,
> > > 
> > > I'm trying to write a quick implementation of usbmon capture in Cython, 
> > > for an Apache-2.0 licensed project[1].
> > > 
> > > As I followed the documentation[2], I realised that the definition of 
> > > ioctl constants and structures for usbmon are not exposed in headers at 
> > > all, only in the sources[3]. This makes it… a bit of a problem, because 
> > > I'm not sure if mimicking the structures in Cython falls into the 
> > > syscall exception at that point.
> > > 
> > > Interesting enough, libpcap appears to define the same values, but 
> > > apply an MIT license to them[4], so I could copy them from there, but I 
> > > thought I would at least check first, if this should be exposed in the 
> > > first place.
> > > 
> > > Please advise!
> > > 
> > > [1]: https://github.com/Flameeyes/usbmon-tools
> > > [2]: https://www.kernel.org/doc/Documentation/usb/usbmon.txt
> > > [3]: https://github.com/torvalds/linux/blob/master/drivers/usb/mon/mon_bin.c
> > > [4]: https://github.com/the-tcpdump-group/libpcap/blob/master/pcap-usb-linux.c
> 
> Yeah, we really should put those structures in include/uapi/ with the
> proper license.  Care to make a patch for it?
> 
> thanks,
> 
> greg k-h
>