[PATCH] dt-bindings: usb: Use OF graph schema

[PATCH] dt-bindings: usb: Use OF graph schema

[Rob Herring]

Now that we have a graph schema, rework the USB related schemas to use
it. Mostly this is adding a reference to graph.yaml and dropping duplicate
parts from schemas.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/usb/renesas,usb3-peri.yaml        | 7 ++++---
 Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml   | 8 ++++----
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
index 929a3f413b44..9fcf54b10b07 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
@@ -54,18 +54,19 @@ properties:
     description: phandle of a companion.
 
   ports:
+    $ref: /schemas/graph.yaml#/properties/ports
     description: |
       any connector to the data bus of this controller should be modelled
       using the OF graph bindings specified, if the "usb-role-switch"
       property is used.
-    type: object
+
     properties:
       port@0:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: High Speed (HS) data bus.
 
       port@1:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Super Speed (SS) data bus.
 
     required:
diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
index 52ceb07294a3..b86bf6bc9cd6 100644
--- a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
@@ -26,17 +26,17 @@ properties:
     maxItems: 1
 
   ports:
+    $ref: /schemas/graph.yaml#/properties/ports
     description: OF graph bindings (specified in bindings/graph.txt) that model
       SS data bus to the SS capable connector.
-    type: object
+
     properties:
       port@0:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Super Speed (SS) MUX inputs connected to SS capable connector.
-        $ref: /connector/usb-connector.yaml#/properties/ports/properties/port@1
 
       port@1:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Output of 2:1 MUX connected to Super Speed (SS) data bus.
 
     required:
-- 
2.27.0

Re: [PATCH] dt-bindings: usb: Use OF graph schema

[Greg Kroah-Hartman]

On Tue, Jan 12, 2021 at 09:35:27AM -0600, Rob Herring wrote:
> Now that we have a graph schema, rework the USB related schemas to use
> it. Mostly this is adding a reference to graph.yaml and dropping duplicate
> parts from schemas.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/usb/renesas,usb3-peri.yaml        | 7 ++++---
>  Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml   | 8 ++++----
>  2 files changed, 8 insertions(+), 7 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

RE: [PATCH] dt-bindings: usb: Use OF graph schema

[Biju Das]

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 12 January 2021 15:35
> To: devicetree@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com>; Biju Das <biju.das.jz@bp.renesas.com>;
> linux-usb@vger.kernel.org
> Subject: [PATCH] dt-bindings: usb: Use OF graph schema
> 
> Now that we have a graph schema, rework the USB related schemas to use it.
> Mostly this is adding a reference to graph.yaml and dropping duplicate
> parts from schemas.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> ---
>  .../devicetree/bindings/usb/renesas,usb3-peri.yaml        | 7 ++++---
>  Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml   | 8 ++++----
>  2 files changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> index 929a3f413b44..9fcf54b10b07 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> @@ -54,18 +54,19 @@ properties:
>      description: phandle of a companion.
> 
>    ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
>      description: |
>        any connector to the data bus of this controller should be modelled
>        using the OF graph bindings specified, if the "usb-role-switch"
>        property is used.
> -    type: object
> +
>      properties:
>        port@0:
> -        type: object
> +        $ref: /schemas/graph.yaml#/properties/port
>          description: High Speed (HS) data bus.
> 
>        port@1:
> -        type: object
> +        $ref: /schemas/graph.yaml#/properties/port
>          description: Super Speed (SS) data bus.
> 
>      required:
> diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> index 52ceb07294a3..b86bf6bc9cd6 100644
> --- a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> @@ -26,17 +26,17 @@ properties:
>      maxItems: 1
> 
>    ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
>      description: OF graph bindings (specified in bindings/graph.txt) that
> model
>        SS data bus to the SS capable connector.
> -    type: object
> +
>      properties:
>        port@0:
> -        type: object
> +        $ref: /schemas/graph.yaml#/properties/port
>          description: Super Speed (SS) MUX inputs connected to SS capable
> connector.
> -        $ref: /connector/usb-
> connector.yaml#/properties/ports/properties/port@1
> 
>        port@1:
> -        type: object
> +        $ref: /schemas/graph.yaml#/properties/port
>          description: Output of 2:1 MUX connected to Super Speed (SS) data
> bus.
> 
>      required:
> --
> 2.27.0

RE: [PATCH] dt-bindings: usb: Use OF graph schema

[Yoshihiro Shimoda]

> From: Rob Herring, Sent: Wednesday, January 13, 2021 12:35 AM
> 
> Now that we have a graph schema, rework the USB related schemas to use
> it. Mostly this is adding a reference to graph.yaml and dropping duplicate
> parts from schemas.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda