[PATCH] usb: typec: mux: select not-visible INTEL_SCU_IPC

[PATCH] usb: typec: mux: select not-visible INTEL_SCU_IPC

[Randy Dunlap]

Use "select INTEL_SCU_IPC" instead of depending on it since it is
not a visible Kconfig symbol and it may not otherwise be set/enabled.

Fixes: b62851491a55 ("usb: typec: mux: Convert the Intel PMC Mux driver to use new SCU IPC API")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/typec/mux/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20220128.orig/drivers/usb/typec/mux/Kconfig
+++ linux-next-20220128/drivers/usb/typec/mux/Kconfig
@@ -12,7 +12,7 @@ config TYPEC_MUX_PI3USB30532
 config TYPEC_MUX_INTEL_PMC
 	tristate "Intel PMC mux control"
 	depends on ACPI
-	depends on INTEL_SCU_IPC
+	select INTEL_SCU_IPC
 	select USB_ROLE_SWITCH
 	help
 	  Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can

Re: [PATCH] usb: typec: mux: select not-visible INTEL_SCU_IPC

[kernel test robot]

Hi Randy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on linux/master linus/master balbi-usb/testing/next peter-chen-usb/for-usb-next v5.17-rc1 next-20220128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Randy-Dunlap/usb-typec-mux-select-not-visible-INTEL_SCU_IPC/20220130-121346
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220130/202201301532.7WyZkoRm-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/15c19e705dc558a4a954897a8a4d369164035341
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Randy-Dunlap/usb-typec-mux-select-not-visible-INTEL_SCU_IPC/20220130-121346
        git checkout 15c19e705dc558a4a954897a8a4d369164035341
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/usb/typec/mux/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/usb/typec/mux/intel_pmc_mux.c:19:10: fatal error: asm/intel_scu_ipc.h: No such file or directory
      19 | #include <asm/intel_scu_ipc.h>
         |          ^~~~~~~~~~~~~~~~~~~~~
   compilation terminated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for INTEL_SCU_IPC
   Depends on X86 && X86_PLATFORM_DEVICES
   Selected by
   - TYPEC_MUX_INTEL_PMC && USB_SUPPORT && TYPEC && ACPI


vim +19 drivers/usb/typec/mux/intel_pmc_mux.c

6701adfa9693bd Heikki Krogerus 2020-03-02  18  
b62851491a55bc Heikki Krogerus 2020-04-16 @19  #include <asm/intel_scu_ipc.h>
6701adfa9693bd Heikki Krogerus 2020-03-02  20  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org