From: Michael Grzeschik <mgr@pengutronix.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, balbi@kernel.org,
kernel@pengutronix.de, Thinh.Nguyen@synopsys.com
Subject: Re: [PATCH v2 2/2] usb: dwc3: gadget: fix high speed multiplier setting
Date: Fri, 8 Jul 2022 14:51:58 +0200 [thread overview]
Message-ID: <20220708125158.GA8524@pengutronix.de> (raw)
In-Reply-To: <Ysgm6nD02TKEYJeq@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
Cc: Thinh.Nguyen@synopsys.com
On Fri, Jul 08, 2022 at 02:45:30PM +0200, Greg KH wrote:
>On Mon, Jul 04, 2022 at 04:18:12PM +0200, Michael Grzeschik wrote:
>> For High-Speed Transfers the prepare_one_trb function is calculating the
>> multiplier setting for the trb based on the length parameter of the trb
>> currently prepared. This assumption is wrong. For trbs with a sg list,
>> the length of the actual request has to be taken instead.
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> ---
>> v1 -> v2: - added refactor patch before this patch
>> - using req->request.length as condition value
>
>Does this need to be backported to older kernels or is it ok for
>5.20-rc1?
We can add this line to the patch.
Fixes: 40d829fb2ec6 ("usb: dwc3: gadget: Correct ISOC DATA PIDs for short packets")
I would say this could be backported.
Thinh?
>thanks,
>
>greg k-h
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-08 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 14:18 [PATCH v2 0/2] fix trb handling for high speed isoc transfers Michael Grzeschik
2022-07-04 14:18 ` [PATCH v2 1/2] usb: dwc3: gadget: refactor dwc3_repare_one_trb Michael Grzeschik
2022-07-08 12:45 ` Greg KH
2022-07-04 14:18 ` [PATCH v2 2/2] usb: dwc3: gadget: fix high speed multiplier setting Michael Grzeschik
2022-07-08 12:45 ` Greg KH
2022-07-08 12:51 ` Michael Grzeschik [this message]
2022-07-08 23:00 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708125158.GA8524@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox