Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: linux-usb@vger.kernel.org, balbi@kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 1/2] usb: dwc3: gadget: refactor dwc3_repare_one_trb
Date: Fri, 8 Jul 2022 14:45:09 +0200	[thread overview]
Message-ID: <Ysgm1fc8Of9PhV7d@kroah.com> (raw)
In-Reply-To: <20220704141812.1532306-2-m.grzeschik@pengutronix.de>

On Mon, Jul 04, 2022 at 04:18:11PM +0200, Michael Grzeschik wrote:
> The function __dwc3_prepare_one_trb has many parameters. Since it is
> only used in dwc3_prepare_one_trb there is no point in keeping the
> function. We merge both functions and get rid of the big list of
> parameters.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> v1 -> v2: - new patch
> 
>  drivers/usb/dwc3/gadget.c | 92 +++++++++++++++++----------------------
>  1 file changed, 40 insertions(+), 52 deletions(-)

Much nicer, thanks!


  reply	other threads:[~2022-07-08 12:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 14:18 [PATCH v2 0/2] fix trb handling for high speed isoc transfers Michael Grzeschik
2022-07-04 14:18 ` [PATCH v2 1/2] usb: dwc3: gadget: refactor dwc3_repare_one_trb Michael Grzeschik
2022-07-08 12:45   ` Greg KH [this message]
2022-07-04 14:18 ` [PATCH v2 2/2] usb: dwc3: gadget: fix high speed multiplier setting Michael Grzeschik
2022-07-08 12:45   ` Greg KH
2022-07-08 12:51     ` Michael Grzeschik
2022-07-08 23:00       ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ysgm1fc8Of9PhV7d@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox