Linux USB
 help / color / mirror / Atom feed
* [PATCH] usb: misc: onboard_usb_hub: Drop obsolete dependency on COMPILE_TEST
@ 2022-11-27 14:52 Jean Delvare
  0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2022-11-27 14:52 UTC (permalink / raw)
  To: linux-usb; +Cc: LKML, Matthias Kaehlcke, Greg Kroah-Hartman

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/misc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-6.0.orig/drivers/usb/misc/Kconfig
+++ linux-6.0/drivers/usb/misc/Kconfig
@@ -298,7 +298,7 @@ config BRCM_USB_PINMAP
 
 config USB_ONBOARD_HUB
 	tristate "Onboard USB hub support"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	  Say Y here if you want to support discrete onboard USB hubs that
 	  don't require an additional control bus for initialization, but


-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-27 14:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-27 14:52 [PATCH] usb: misc: onboard_usb_hub: Drop obsolete dependency on COMPILE_TEST Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox