Linux USB
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: <mika.westerberg@linux.intel.com>, <linux-usb@vger.kernel.org>
Cc: <YehezkelShB@gmail.com>, <michael.jamet@intel.com>,
	<andreas.noever@gmail.com>, <Sanju.Mehta@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] Fix problems fetching TBT3 DROM from AMD USB4 routers
Date: Tue, 14 Feb 2023 09:46:44 -0600	[thread overview]
Message-ID: <20230214154647.874-1-mario.limonciello@amd.com> (raw)

TBT3 devices when connected to an AMD USB4 router occasionally fail to
properly respond to requests for the DROM via bit banging.

Depending upon which part of the request failed will impact the severity.
A number of workarounds have been put in place to let the driver handle
the failed requests:

e87491a9fd4e3 ("thunderbolt: Retry DROM reads for more failure scenarios")
a283de3ec646f ("thunderbolt: Do not resume routers if UID is not set")
6915812bbd109 ("thunderbolt: Do not make DROM read success compulsory")

Still even with these changes the failures do make it through. In comparing
other CM implementations, they all access the DROM directly from the NVM.

To avoid triggering this issue, try to get the DROM directly from the NVM
in Linux as well before resorting to bitbanging.

Mario Limonciello (2):
  thunderbolt: Read DROM directly from NVM before trying bit banging
  thunderbolt: use `tb_eeprom_get_drom_offset` to discover DROM offset

 drivers/thunderbolt/eeprom.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

-- 
2.25.1


             reply	other threads:[~2023-02-14 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 15:46 Mario Limonciello [this message]
2023-02-14 15:46 ` [PATCH 1/2] thunderbolt: Read DROM directly from NVM before trying bit banging Mario Limonciello
2023-02-15  5:58   ` Mika Westerberg
2023-02-15  6:10     ` Mario Limonciello
2023-02-15  6:24       ` Mika Westerberg
2023-02-15  7:26         ` Mika Westerberg
2023-02-14 15:46 ` [PATCH 2/2] thunderbolt: use `tb_eeprom_get_drom_offset` to discover DROM offset Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214154647.874-1-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Sanju.Mehta@amd.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox