From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Sanju.Mehta@amd.com, stable@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thunderbolt: Read DROM directly from NVM before trying bit banging
Date: Wed, 15 Feb 2023 09:26:10 +0200 [thread overview]
Message-ID: <Y+yJEjLa9R1JGlIu@black.fi.intel.com> (raw)
In-Reply-To: <Y+x6pwHKDe2gXNUY@black.fi.intel.com>
On Wed, Feb 15, 2023 at 08:24:39AM +0200, Mika Westerberg wrote:
> > I guess something else that might be less detrimental the loss of UUID
> > by reading DROM this way would be to only read DROM this way if any CRC
> > failed.
>
> Actually we do read UUID for TBT3 devices from link controller registers
> (see tb_lc_read_uuid()) instead so I think perhaps we can limit the
> bitbanging just for older TBT devices with no LC or something like that?
Just make sure UUID stays the same so that users don't need to
re-authorize their devices.
next prev parent reply other threads:[~2023-02-15 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 15:46 [PATCH 0/2] Fix problems fetching TBT3 DROM from AMD USB4 routers Mario Limonciello
2023-02-14 15:46 ` [PATCH 1/2] thunderbolt: Read DROM directly from NVM before trying bit banging Mario Limonciello
2023-02-15 5:58 ` Mika Westerberg
2023-02-15 6:10 ` Mario Limonciello
2023-02-15 6:24 ` Mika Westerberg
2023-02-15 7:26 ` Mika Westerberg [this message]
2023-02-14 15:46 ` [PATCH 2/2] thunderbolt: use `tb_eeprom_get_drom_offset` to discover DROM offset Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+yJEjLa9R1JGlIu@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Sanju.Mehta@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox