* [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32
@ 2023-05-16 8:34 Krzysztof Kozlowski
2023-05-16 8:48 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-16 8:34 UTC (permalink / raw)
To: Richard Leitner, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Marek Vasut, linux-usb,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski, mike.looijmans
The "swap-dx-lanes" was never described as uint8 in original TXT
bindings and Linux driver expects uint32. Fix the type to match Linux
driver expectation.
Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
1. Correct commit msg typo (Marek)
Cc: marex@denx.de
Cc: mike.looijmans@topic.nl
---
Documentation/devicetree/bindings/usb/usb251xb.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml
index 4d1530816817..ac5b99710332 100644
--- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
+++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
@@ -231,7 +231,7 @@ properties:
power-on sequence to a port until the port has adequate power.
swap-dx-lanes:
- $ref: /schemas/types.yaml#/definitions/uint8-array
+ $ref: /schemas/types.yaml#/definitions/uint32-array
description: |
Specifies the ports which will swap the differential-pair (D+/D-),
default is not-swapped.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32
2023-05-16 8:34 [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32 Krzysztof Kozlowski
@ 2023-05-16 8:48 ` Marek Vasut
2023-05-16 13:02 ` Richard Leitner
2023-05-16 17:27 ` Conor Dooley
2 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2023-05-16 8:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Richard Leitner, Greg Kroah-Hartman,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-usb,
devicetree, linux-kernel
Cc: mike.looijmans
On 5/16/23 10:34, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linux driver expects uint32. Fix the type to match Linux
> driver expectation.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32
2023-05-16 8:34 [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32 Krzysztof Kozlowski
2023-05-16 8:48 ` Marek Vasut
@ 2023-05-16 13:02 ` Richard Leitner
2023-05-16 17:27 ` Conor Dooley
2 siblings, 0 replies; 4+ messages in thread
From: Richard Leitner @ 2023-05-16 13:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Marek Vasut, linux-usb, devicetree, linux-kernel,
mike.looijmans
On Tue, May 16, 2023 at 10:34:32AM +0200, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linux driver expects uint32. Fix the type to match Linux
> driver expectation.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
LGTM. Please feel free to add
Reviewed-by: Richard Leitner <richard.leitner@linux.dev>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32
2023-05-16 8:34 [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32 Krzysztof Kozlowski
2023-05-16 8:48 ` Marek Vasut
2023-05-16 13:02 ` Richard Leitner
@ 2023-05-16 17:27 ` Conor Dooley
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2023-05-16 17:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Richard Leitner, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Marek Vasut, linux-usb,
devicetree, linux-kernel, mike.looijmans
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
On Tue, May 16, 2023 at 10:34:32AM +0200, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linux driver expects uint32. Fix the type to match Linux
> driver expectation.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-16 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 8:34 [PATCH v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32 Krzysztof Kozlowski
2023-05-16 8:48 ` Marek Vasut
2023-05-16 13:02 ` Richard Leitner
2023-05-16 17:27 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox