* [v4,2/2] usb: typec: tcpm: add get max power support
2023-06-16 7:52 [v4,1/2] usb: typec: tcpm: fix cc role at port reset Frank Wang
@ 2023-06-16 7:52 ` Frank Wang
2023-06-16 8:36 ` Guenter Roeck
2023-06-26 8:39 ` Heikki Krogerus
2023-06-16 8:33 ` [v4,1/2] usb: typec: tcpm: fix cc role at port reset Guenter Roeck
2023-06-26 8:35 ` Heikki Krogerus
2 siblings, 2 replies; 6+ messages in thread
From: Frank Wang @ 2023-06-16 7:52 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh, sebastian.reichel, heiko
Cc: linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc, Frank Wang
Traverse fixed pdos to calculate the maximum power that the charger
can provide, and it can be get by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
property.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
Changelog:
v4:
- No change
v3:
- Use Microwatts instead of Milliwatts to follow the ABI, commented by Sebastian Reichel.
v2:
- No change
v1:
- https://patchwork.kernel.org/project/linux-usb/patch/20230313025843.17162-4-frank.wang@rock-chips.com/
drivers/usb/typec/tcpm/tcpm.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 9f6aaa3e70ca8..829d75ebab422 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -6340,6 +6340,27 @@ static int tcpm_psy_get_current_now(struct tcpm_port *port,
return 0;
}
+static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
+ union power_supply_propval *val)
+{
+ unsigned int src_mv, src_ma, max_src_uw = 0;
+ unsigned int i, tmp;
+
+ for (i = 0; i < port->nr_source_caps; i++) {
+ u32 pdo = port->source_caps[i];
+
+ if (pdo_type(pdo) == PDO_TYPE_FIXED) {
+ src_mv = pdo_fixed_voltage(pdo);
+ src_ma = pdo_max_current(pdo);
+ tmp = src_mv * src_ma;
+ max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
+ }
+ }
+
+ val->intval = max_src_uw;
+ return 0;
+}
+
static int tcpm_psy_get_prop(struct power_supply *psy,
enum power_supply_property psp,
union power_supply_propval *val)
@@ -6369,6 +6390,9 @@ static int tcpm_psy_get_prop(struct power_supply *psy,
case POWER_SUPPLY_PROP_CURRENT_NOW:
ret = tcpm_psy_get_current_now(port, val);
break;
+ case POWER_SUPPLY_PROP_INPUT_POWER_LIMIT:
+ tcpm_psy_get_input_power_limit(port, val);
+ break;
default:
ret = -EINVAL;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [v4,2/2] usb: typec: tcpm: add get max power support
2023-06-16 7:52 ` [v4,2/2] usb: typec: tcpm: add get max power support Frank Wang
@ 2023-06-16 8:36 ` Guenter Roeck
2023-06-26 8:39 ` Heikki Krogerus
1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2023-06-16 8:36 UTC (permalink / raw)
To: Frank Wang, heikki.krogerus, gregkh, sebastian.reichel, heiko
Cc: linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc
On 6/16/23 00:52, Frank Wang wrote:
> Traverse fixed pdos to calculate the maximum power that the charger
> can provide, and it can be get by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
> property.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changelog:
> v4:
> - No change
>
> v3:
> - Use Microwatts instead of Milliwatts to follow the ABI, commented by Sebastian Reichel.
>
> v2:
> - No change
>
> v1:
> - https://patchwork.kernel.org/project/linux-usb/patch/20230313025843.17162-4-frank.wang@rock-chips.com/
>
> drivers/usb/typec/tcpm/tcpm.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 9f6aaa3e70ca8..829d75ebab422 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6340,6 +6340,27 @@ static int tcpm_psy_get_current_now(struct tcpm_port *port,
> return 0;
> }
>
> +static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
> + union power_supply_propval *val)
> +{
> + unsigned int src_mv, src_ma, max_src_uw = 0;
> + unsigned int i, tmp;
> +
> + for (i = 0; i < port->nr_source_caps; i++) {
> + u32 pdo = port->source_caps[i];
> +
> + if (pdo_type(pdo) == PDO_TYPE_FIXED) {
> + src_mv = pdo_fixed_voltage(pdo);
> + src_ma = pdo_max_current(pdo);
> + tmp = src_mv * src_ma;
> + max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
> + }
> + }
> +
> + val->intval = max_src_uw;
> + return 0;
> +}
> +
> static int tcpm_psy_get_prop(struct power_supply *psy,
> enum power_supply_property psp,
> union power_supply_propval *val)
> @@ -6369,6 +6390,9 @@ static int tcpm_psy_get_prop(struct power_supply *psy,
> case POWER_SUPPLY_PROP_CURRENT_NOW:
> ret = tcpm_psy_get_current_now(port, val);
> break;
> + case POWER_SUPPLY_PROP_INPUT_POWER_LIMIT:
> + tcpm_psy_get_input_power_limit(port, val);
> + break;
> default:
> ret = -EINVAL;
> break;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [v4,2/2] usb: typec: tcpm: add get max power support
2023-06-16 7:52 ` [v4,2/2] usb: typec: tcpm: add get max power support Frank Wang
2023-06-16 8:36 ` Guenter Roeck
@ 2023-06-26 8:39 ` Heikki Krogerus
1 sibling, 0 replies; 6+ messages in thread
From: Heikki Krogerus @ 2023-06-26 8:39 UTC (permalink / raw)
To: Frank Wang
Cc: linux, gregkh, sebastian.reichel, heiko, linux-usb, linux-kernel,
linux-rockchip, huangtao, william.wu, jianwei.zheng, yubing.zhang,
wmc
On Fri, Jun 16, 2023 at 03:52:41PM +0800, Frank Wang wrote:
> Traverse fixed pdos to calculate the maximum power that the charger
> can provide, and it can be get by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
> property.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changelog:
> v4:
> - No change
>
> v3:
> - Use Microwatts instead of Milliwatts to follow the ABI, commented by Sebastian Reichel.
>
> v2:
> - No change
>
> v1:
> - https://patchwork.kernel.org/project/linux-usb/patch/20230313025843.17162-4-frank.wang@rock-chips.com/
>
> drivers/usb/typec/tcpm/tcpm.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 9f6aaa3e70ca8..829d75ebab422 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6340,6 +6340,27 @@ static int tcpm_psy_get_current_now(struct tcpm_port *port,
> return 0;
> }
>
> +static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
> + union power_supply_propval *val)
> +{
> + unsigned int src_mv, src_ma, max_src_uw = 0;
> + unsigned int i, tmp;
> +
> + for (i = 0; i < port->nr_source_caps; i++) {
> + u32 pdo = port->source_caps[i];
> +
> + if (pdo_type(pdo) == PDO_TYPE_FIXED) {
> + src_mv = pdo_fixed_voltage(pdo);
> + src_ma = pdo_max_current(pdo);
> + tmp = src_mv * src_ma;
> + max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
> + }
> + }
> +
> + val->intval = max_src_uw;
> + return 0;
> +}
> +
> static int tcpm_psy_get_prop(struct power_supply *psy,
> enum power_supply_property psp,
> union power_supply_propval *val)
> @@ -6369,6 +6390,9 @@ static int tcpm_psy_get_prop(struct power_supply *psy,
> case POWER_SUPPLY_PROP_CURRENT_NOW:
> ret = tcpm_psy_get_current_now(port, val);
> break;
> + case POWER_SUPPLY_PROP_INPUT_POWER_LIMIT:
> + tcpm_psy_get_input_power_limit(port, val);
> + break;
> default:
> ret = -EINVAL;
> break;
> --
> 2.17.1
--
heikki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [v4,1/2] usb: typec: tcpm: fix cc role at port reset
2023-06-16 7:52 [v4,1/2] usb: typec: tcpm: fix cc role at port reset Frank Wang
2023-06-16 7:52 ` [v4,2/2] usb: typec: tcpm: add get max power support Frank Wang
@ 2023-06-16 8:33 ` Guenter Roeck
2023-06-26 8:35 ` Heikki Krogerus
2 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2023-06-16 8:33 UTC (permalink / raw)
To: Frank Wang, heikki.krogerus, gregkh, sebastian.reichel, heiko
Cc: linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc
On 6/16/23 00:52, Frank Wang wrote:
> In the current implementation, the tcpm set CC1/CC2 role to open when
> it do port reset would cause the VBUS removed by the Type-C partner.
>
> This sets CC1/CC2 according to the default state of port to fix it.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changelog:
> (no changes since v3)
>
> v2:
> - Make some tweaking based on the default state of port, commented by Guenter Roeck.
>
Specifically: Do not set the state to TYPEC_CC_RD unconditionally
but make it dependent on the port's default state.
Guenter
> v1:
> - https://patchwork.kernel.org/project/linux-usb/patch/20230313025843.17162-2-frank.wang@rock-chips.com/
>
> drivers/usb/typec/tcpm/tcpm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 3c6b0c8e2d3ae..9f6aaa3e70ca8 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4885,7 +4885,8 @@ static void run_state_machine(struct tcpm_port *port)
> break;
> case PORT_RESET:
> tcpm_reset_port(port);
> - tcpm_set_cc(port, TYPEC_CC_OPEN);
> + tcpm_set_cc(port, tcpm_default_state(port) == SNK_UNATTACHED ?
> + TYPEC_CC_RD : tcpm_rp_cc(port));
> tcpm_set_state(port, PORT_RESET_WAIT_OFF,
> PD_T_ERROR_RECOVERY);
> break;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [v4,1/2] usb: typec: tcpm: fix cc role at port reset
2023-06-16 7:52 [v4,1/2] usb: typec: tcpm: fix cc role at port reset Frank Wang
2023-06-16 7:52 ` [v4,2/2] usb: typec: tcpm: add get max power support Frank Wang
2023-06-16 8:33 ` [v4,1/2] usb: typec: tcpm: fix cc role at port reset Guenter Roeck
@ 2023-06-26 8:35 ` Heikki Krogerus
2 siblings, 0 replies; 6+ messages in thread
From: Heikki Krogerus @ 2023-06-26 8:35 UTC (permalink / raw)
To: Frank Wang
Cc: linux, gregkh, sebastian.reichel, heiko, linux-usb, linux-kernel,
linux-rockchip, huangtao, william.wu, jianwei.zheng, yubing.zhang,
wmc
On Fri, Jun 16, 2023 at 03:52:40PM +0800, Frank Wang wrote:
> In the current implementation, the tcpm set CC1/CC2 role to open when
> it do port reset would cause the VBUS removed by the Type-C partner.
>
> This sets CC1/CC2 according to the default state of port to fix it.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changelog:
> (no changes since v3)
>
> v2:
> - Make some tweaking based on the default state of port, commented by Guenter Roeck.
>
> v1:
> - https://patchwork.kernel.org/project/linux-usb/patch/20230313025843.17162-2-frank.wang@rock-chips.com/
>
> drivers/usb/typec/tcpm/tcpm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 3c6b0c8e2d3ae..9f6aaa3e70ca8 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4885,7 +4885,8 @@ static void run_state_machine(struct tcpm_port *port)
> break;
> case PORT_RESET:
> tcpm_reset_port(port);
> - tcpm_set_cc(port, TYPEC_CC_OPEN);
> + tcpm_set_cc(port, tcpm_default_state(port) == SNK_UNATTACHED ?
> + TYPEC_CC_RD : tcpm_rp_cc(port));
> tcpm_set_state(port, PORT_RESET_WAIT_OFF,
> PD_T_ERROR_RECOVERY);
> break;
thanks,
--
heikki
^ permalink raw reply [flat|nested] 6+ messages in thread