* usb: typec: tcpm: add get max power support
@ 2023-06-16 2:21 Frank Wang
2023-06-16 2:26 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wang @ 2023-06-16 2:21 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh, sebastian.reichel, heiko
Cc: linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc, Frank Wang
Traverse fixed pdos to calculate the maximum power that the charger
can provide, and it can be got by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
property.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
drivers/usb/typec/tcpm/tcpm.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 9f6aaa3e70ca8..829d75ebab422 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -6340,6 +6340,27 @@ static int tcpm_psy_get_current_now(struct tcpm_port *port,
return 0;
}
+static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
+ union power_supply_propval *val)
+{
+ unsigned int src_mv, src_ma, max_src_uw = 0;
+ unsigned int i, tmp;
+
+ for (i = 0; i < port->nr_source_caps; i++) {
+ u32 pdo = port->source_caps[i];
+
+ if (pdo_type(pdo) == PDO_TYPE_FIXED) {
+ src_mv = pdo_fixed_voltage(pdo);
+ src_ma = pdo_max_current(pdo);
+ tmp = src_mv * src_ma;
+ max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
+ }
+ }
+
+ val->intval = max_src_uw;
+ return 0;
+}
+
static int tcpm_psy_get_prop(struct power_supply *psy,
enum power_supply_property psp,
union power_supply_propval *val)
@@ -6369,6 +6390,9 @@ static int tcpm_psy_get_prop(struct power_supply *psy,
case POWER_SUPPLY_PROP_CURRENT_NOW:
ret = tcpm_psy_get_current_now(port, val);
break;
+ case POWER_SUPPLY_PROP_INPUT_POWER_LIMIT:
+ tcpm_psy_get_input_power_limit(port, val);
+ break;
default:
ret = -EINVAL;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: usb: typec: tcpm: add get max power support
2023-06-16 2:21 usb: typec: tcpm: add get max power support Frank Wang
@ 2023-06-16 2:26 ` Guenter Roeck
2023-06-16 3:13 ` Frank Wang
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2023-06-16 2:26 UTC (permalink / raw)
To: Frank Wang, heikki.krogerus, gregkh, sebastian.reichel, heiko
Cc: linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc
On 6/15/23 19:21, Frank Wang wrote:
> Traverse fixed pdos to calculate the maximum power that the charger
> can provide, and it can be got by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
> property.
>
Wasn't this already v3 before ? What happened to the version, and the change log ?
Or is this a completely different/new patch ?
Guenter
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 9f6aaa3e70ca8..829d75ebab422 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6340,6 +6340,27 @@ static int tcpm_psy_get_current_now(struct tcpm_port *port,
> return 0;
> }
>
> +static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
> + union power_supply_propval *val)
> +{
> + unsigned int src_mv, src_ma, max_src_uw = 0;
> + unsigned int i, tmp;
> +
> + for (i = 0; i < port->nr_source_caps; i++) {
> + u32 pdo = port->source_caps[i];
> +
> + if (pdo_type(pdo) == PDO_TYPE_FIXED) {
> + src_mv = pdo_fixed_voltage(pdo);
> + src_ma = pdo_max_current(pdo);
> + tmp = src_mv * src_ma;
> + max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
> + }
> + }
> +
> + val->intval = max_src_uw;
> + return 0;
> +}
> +
> static int tcpm_psy_get_prop(struct power_supply *psy,
> enum power_supply_property psp,
> union power_supply_propval *val)
> @@ -6369,6 +6390,9 @@ static int tcpm_psy_get_prop(struct power_supply *psy,
> case POWER_SUPPLY_PROP_CURRENT_NOW:
> ret = tcpm_psy_get_current_now(port, val);
> break;
> + case POWER_SUPPLY_PROP_INPUT_POWER_LIMIT:
> + tcpm_psy_get_input_power_limit(port, val);
> + break;
> default:
> ret = -EINVAL;
> break;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: usb: typec: tcpm: add get max power support
2023-06-16 2:26 ` Guenter Roeck
@ 2023-06-16 3:13 ` Frank Wang
2023-06-16 6:05 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wang @ 2023-06-16 3:13 UTC (permalink / raw)
To: Guenter Roeck, heikki.krogerus, gregkh, sebastian.reichel, heiko
Cc: linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc
Hi Guenter,
On 2023/6/16 10:26, Guenter Roeck wrote:
> On 6/15/23 19:21, Frank Wang wrote:
>> Traverse fixed pdos to calculate the maximum power that the charger
>> can provide, and it can be got by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
>> property.
>>
>
> Wasn't this already v3 before ? What happened to the version, and the
> change log ?
> Or is this a completely different/new patch ?
>
Yes, it is the v3 patch before which has been hold for a long time,
Gregkh asked me to rebase it and resubmit, so should I also add an
"RESEND" tag in subject?
BR.
Frank
> Guenter
>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>> ---
>> drivers/usb/typec/tcpm/tcpm.c | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c
>> b/drivers/usb/typec/tcpm/tcpm.c
>> index 9f6aaa3e70ca8..829d75ebab422 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -6340,6 +6340,27 @@ static int tcpm_psy_get_current_now(struct
>> tcpm_port *port,
>> return 0;
>> }
>> +static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
>> + union power_supply_propval *val)
>> +{
>> + unsigned int src_mv, src_ma, max_src_uw = 0;
>> + unsigned int i, tmp;
>> +
>> + for (i = 0; i < port->nr_source_caps; i++) {
>> + u32 pdo = port->source_caps[i];
>> +
>> + if (pdo_type(pdo) == PDO_TYPE_FIXED) {
>> + src_mv = pdo_fixed_voltage(pdo);
>> + src_ma = pdo_max_current(pdo);
>> + tmp = src_mv * src_ma;
>> + max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
>> + }
>> + }
>> +
>> + val->intval = max_src_uw;
>> + return 0;
>> +}
>> +
>> static int tcpm_psy_get_prop(struct power_supply *psy,
>> enum power_supply_property psp,
>> union power_supply_propval *val)
>> @@ -6369,6 +6390,9 @@ static int tcpm_psy_get_prop(struct
>> power_supply *psy,
>> case POWER_SUPPLY_PROP_CURRENT_NOW:
>> ret = tcpm_psy_get_current_now(port, val);
>> break;
>> + case POWER_SUPPLY_PROP_INPUT_POWER_LIMIT:
>> + tcpm_psy_get_input_power_limit(port, val);
>> + break;
>> default:
>> ret = -EINVAL;
>> break;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: usb: typec: tcpm: add get max power support
2023-06-16 3:13 ` Frank Wang
@ 2023-06-16 6:05 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2023-06-16 6:05 UTC (permalink / raw)
To: Frank Wang
Cc: Guenter Roeck, heikki.krogerus, sebastian.reichel, heiko,
linux-usb, linux-kernel, linux-rockchip, huangtao, william.wu,
jianwei.zheng, yubing.zhang, wmc
On Fri, Jun 16, 2023 at 11:13:08AM +0800, Frank Wang wrote:
> Hi Guenter,
>
> On 2023/6/16 10:26, Guenter Roeck wrote:
> > On 6/15/23 19:21, Frank Wang wrote:
> > > Traverse fixed pdos to calculate the maximum power that the charger
> > > can provide, and it can be got by POWER_SUPPLY_PROP_INPUT_POWER_LIMIT
> > > property.
> > >
> >
> > Wasn't this already v3 before ? What happened to the version, and the
> > change log ?
> > Or is this a completely different/new patch ?
> >
>
> Yes, it is the v3 patch before which has been hold for a long time, Gregkh
> asked me to rebase it and resubmit, so should I also add an "RESEND" tag in
> subject?
Yes, please do, otherwise we have no idea what is going on here.
Please resend v4 with all of the change information.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-16 6:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-16 2:21 usb: typec: tcpm: add get max power support Frank Wang
2023-06-16 2:26 ` Guenter Roeck
2023-06-16 3:13 ` Frank Wang
2023-06-16 6:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox