From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg KH <gregkh@linuxfoundation.org>,
Khazhy Kumykov <khazhy@google.com>,
USB mailing list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 0/3] USB: core: Don't overwrite device descriptor during reinitialization
Date: Fri, 11 Aug 2023 17:05:12 +0000 [thread overview]
Message-ID: <20230811170500.xbjyzmcslvajs2qv@synopsys.com> (raw)
In-Reply-To: <3c63cad6-55ef-46dd-90b7-d19cbefedbea@rowland.harvard.edu>
On Thu, Aug 10, 2023, Alan Stern wrote:
> On Thu, Aug 10, 2023 at 10:39:36PM +0000, Thinh Nguyen wrote:
> > On Thu, Aug 10, 2023, Alan Stern wrote:
> > > Never mind; I found the problem. I had forgotten that at SuperSpeed or
> > > faster, the device descriptor uses a logarithmic encoding for
> > > bMaxPacketSize0.
> > >
> > > The patch below should fix things up. Let me know how it goes.
> > >
> >
> > Quick test for Gen 1 and 2 devices work fine now. Highspeed also works
> > as expected before. I didn't test Fullspeed with various MPS, but I
> > don't expect any problem looking at the change.
> >
> > Thanks for the fix,
>
> And thanks for testing it. Is it okay to put your
> "Reported-and-tested-by:" tag on the submitted patch?
>
Yes.
BR,
Thinh
next prev parent reply other threads:[~2023-08-11 17:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 19:09 [PATCH 0/3] USB: core: Don't overwrite device descriptor during reinitialization Alan Stern
2023-08-04 19:10 ` [PATCH 1/3] USB: core: Unite old scheme and new scheme descriptor reads Alan Stern
2023-08-04 19:12 ` [PATCH 2/3] USB: core: Change usb_get_device_descriptor() API Alan Stern
2023-08-04 19:14 ` [PATCH 3/3] USB: core: Fix race by not overwriting udev->descriptor in hub_port_init() Alan Stern
2023-12-11 10:40 ` [REGRESSION] Re: [PATCH 1/3] USB: core: Unite old scheme and new scheme descriptor reads Christian Eggers
2023-12-11 16:21 ` Alan Stern
2023-12-12 8:01 ` Christian Eggers
2023-08-08 8:47 ` [PATCH 0/3] USB: core: Don't overwrite device descriptor during reinitialization Greg KH
2023-08-10 0:28 ` Thinh Nguyen
2023-08-10 1:47 ` Alan Stern
2023-08-10 16:34 ` Alan Stern
2023-08-10 22:39 ` Thinh Nguyen
2023-08-11 1:52 ` Alan Stern
2023-08-11 17:05 ` Thinh Nguyen [this message]
2023-08-11 17:38 ` [PATCH] USB: core: Fix oversight in SuperSpeed initialization Alan Stern
2023-08-12 8:05 ` Greg KH
2023-08-12 15:28 ` Alan Stern
2024-03-05 8:20 ` [REGRESSION] Re: [PATCH 0/3] USB: core: Don't overwrite device descriptor during reinitialization Jan Čermák
2024-03-06 21:08 ` Alan Stern
2024-03-07 16:17 ` Jan Čermák
2024-03-07 19:34 ` Alan Stern
2024-03-11 9:58 ` Jan Čermák
2024-03-11 14:43 ` Alan Stern
2024-03-12 8:57 ` Jan Čermák
2024-03-12 20:47 ` Alan Stern
2024-03-16 20:35 ` Alan Stern
2024-03-19 11:54 ` Jan Čermák
2024-03-19 16:03 ` Alan Stern
2024-03-27 13:24 ` Jan Čermák
2024-03-27 14:21 ` Alan Stern
2024-03-28 15:44 ` Alexander Dahl
2024-03-28 16:16 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811170500.xbjyzmcslvajs2qv@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=khazhy@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox