[PATCH v2] usb: typec: intel_pmc_mux: enable sysfs usb role access

[PATCH v2] usb: typec: intel_pmc_mux: enable sysfs usb role access

[Uday M Bhat]

The OS, such as ChromeOS, uses Android Runtime to run Android applications.
This necessitates supporting tools, for example, Android Debugger (ADB).
On host to host setup xHC.DbC shall support ADB with USB. This requires
user space to control USB roles.

Enable user space control to modify the USB Type-C role. At run time
it will create a role attribute in /sys/class/usb_role/<switch>/.
Attribute can be modified based on the values suggested in the
Documentation/ABI/testing/sysfs-class-usb_role.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Uday M Bhat <uday.m.bhat@intel.com>
---
 drivers/usb/typec/mux/intel_pmc_mux.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
index 60ed1f809130..12a4f49e870e 100644
--- a/drivers/usb/typec/mux/intel_pmc_mux.c
+++ b/drivers/usb/typec/mux/intel_pmc_mux.c
@@ -599,6 +599,7 @@ static int pmc_usb_register_port(struct pmc_usb *pmc, int index,
 	desc.driver_data = port;
 	desc.name = fwnode_get_name(fwnode);
 	desc.set = pmc_usb_set_role;
+	desc.allow_userspace_control = true;
 
 	port->usb_sw = usb_role_switch_register(pmc->dev, &desc);
 	if (IS_ERR(port->usb_sw)) {
-- 
2.17.1

Re: [PATCH v2] usb: typec: intel_pmc_mux: enable sysfs usb role access

[Greg KH]

On Fri, Aug 25, 2023 at 11:51:57AM +0530, Uday M Bhat wrote:
> The OS, such as ChromeOS, uses Android Runtime to run Android applications.
> This necessitates supporting tools, for example, Android Debugger (ADB).
> On host to host setup xHC.DbC shall support ADB with USB. This requires
> user space to control USB roles.
> 
> Enable user space control to modify the USB Type-C role. At run time
> it will create a role attribute in /sys/class/usb_role/<switch>/.
> Attribute can be modified based on the values suggested in the
> Documentation/ABI/testing/sysfs-class-usb_role.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Uday M Bhat <uday.m.bhat@intel.com>
> ---
>  drivers/usb/typec/mux/intel_pmc_mux.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
> index 60ed1f809130..12a4f49e870e 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -599,6 +599,7 @@ static int pmc_usb_register_port(struct pmc_usb *pmc, int index,
>  	desc.driver_data = port;
>  	desc.name = fwnode_get_name(fwnode);
>  	desc.set = pmc_usb_set_role;
> +	desc.allow_userspace_control = true;
>  
>  	port->usb_sw = usb_role_switch_register(pmc->dev, &desc);
>  	if (IS_ERR(port->usb_sw)) {
> -- 
> 2.17.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot