* USB: ftdi_sio: Actisense PIDs constant Names
[not found] ` <ZXq4A-Uht67KcJNV@hovoldconsulting.com>
@ 2023-12-20 11:17 ` Mark Glover
2023-12-20 13:26 ` Greg KH
2023-12-20 13:57 ` Mark Glover
0 siblings, 2 replies; 4+ messages in thread
From: Mark Glover @ 2023-12-20 11:17 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb@vger.kernel.org
[This patch] changes the constant names for unused USB PIDs (product identifiers) to reflect the new products now using the PIDs.
Signed-off-by: Mark Glover <mark.glover@actisense.com>
diff -urN linux-6.6.4/drivers/usb/serial/ftdi_sio.c linux/drivers/usb/serial/ftdi_sio.c
--- linux-6.6.4/drivers/usb/serial/ftdi_sio.c 2023-12-03 06:33:10.000000000 +0000
+++ linux/drivers/usb/serial/ftdi_sio.c 2023-12-12 10:39:51.157327241 +0000
@@ -1033,9 +1033,9 @@
{ USB_DEVICE(FTDI_VID, ACTISENSE_USG_PID) },
{ USB_DEVICE(FTDI_VID, ACTISENSE_NGT_PID) },
{ USB_DEVICE(FTDI_VID, ACTISENSE_NGW_PID) },
- { USB_DEVICE(FTDI_VID, ACTISENSE_D9AC_PID) },
- { USB_DEVICE(FTDI_VID, ACTISENSE_D9AD_PID) },
- { USB_DEVICE(FTDI_VID, ACTISENSE_D9AE_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_UID_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_USA_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGX_PID) },
{ USB_DEVICE(FTDI_VID, ACTISENSE_D9AF_PID) },
{ USB_DEVICE(FTDI_VID, CHETCO_SEAGAUGE_PID) },
{ USB_DEVICE(FTDI_VID, CHETCO_SEASWITCH_PID) },
diff -urN linux-6.6.4/drivers/usb/serial/ftdi_sio_ids.h linux/drivers/usb/serial/ftdi_sio_ids.h
--- linux-6.6.4/drivers/usb/serial/ftdi_sio_ids.h 2023-12-03 06:33:10.000000000 +0000
+++ linux/drivers/usb/serial/ftdi_sio_ids.h 2023-12-12 10:36:37.295990528 +0000
@@ -1568,9 +1568,9 @@
#define ACTISENSE_USG_PID 0xD9A9 /* USG USB Serial Adapter */
#define ACTISENSE_NGT_PID 0xD9AA /* NGT NMEA2000 Interface */
#define ACTISENSE_NGW_PID 0xD9AB /* NGW NMEA2000 Gateway */
-#define ACTISENSE_D9AC_PID 0xD9AC /* Actisense Reserved */
-#define ACTISENSE_D9AD_PID 0xD9AD /* Actisense Reserved */
-#define ACTISENSE_D9AE_PID 0xD9AE /* Actisense Reserved */
+#define ACTISENSE_UID_PID 0xD9AC /* USB Isolating Device */
+#define ACTISENSE_USA_PID 0xD9AD /* USB to Serial Adapter */
+#define ACTISENSE_NGX_PID 0xD9AE /* NGX NMEA2000 Gateway */
#define ACTISENSE_D9AF_PID 0xD9AF /* Actisense Reserved */
#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */
#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Adapter */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: USB: ftdi_sio: Actisense PIDs constant Names
2023-12-20 11:17 ` USB: ftdi_sio: Actisense PIDs constant Names Mark Glover
@ 2023-12-20 13:26 ` Greg KH
2023-12-20 13:57 ` Mark Glover
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2023-12-20 13:26 UTC (permalink / raw)
To: Mark Glover; +Cc: Johan Hovold, linux-usb@vger.kernel.org
On Wed, Dec 20, 2023 at 11:17:40AM +0000, Mark Glover wrote:
> [This patch] changes the constant names for unused USB PIDs (product identifiers) to reflect the new products now using the PIDs.
No need for "[This patch]", right?
Also, can you wrap your lines at 72 columns?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: ftdi_sio: Actisense PIDs constant Names
2023-12-20 11:17 ` USB: ftdi_sio: Actisense PIDs constant Names Mark Glover
2023-12-20 13:26 ` Greg KH
@ 2023-12-20 13:57 ` Mark Glover
2023-12-21 8:14 ` Johan Hovold
1 sibling, 1 reply; 4+ messages in thread
From: Mark Glover @ 2023-12-20 13:57 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb@vger.kernel.org
This changes the constant names for unused USB PIDs (product identifiers)
to reflect the new products now using the PIDs.
Signed-off-by: Mark Glover <mark.glover@actisense.com>
diff -urN linux-6.6.4/drivers/usb/serial/ftdi_sio.c linux/drivers/usb/serial/ftdi_sio.c
--- linux-6.6.4/drivers/usb/serial/ftdi_sio.c 2023-12-03 06:33:10.000000000 +0000
+++ linux/drivers/usb/serial/ftdi_sio.c 2023-12-12 10:39:51.157327241 +0000
@@ -1033,9 +1033,9 @@
{ USB_DEVICE(FTDI_VID, ACTISENSE_USG_PID) },
{ USB_DEVICE(FTDI_VID, ACTISENSE_NGT_PID) },
{ USB_DEVICE(FTDI_VID, ACTISENSE_NGW_PID) },
- { USB_DEVICE(FTDI_VID, ACTISENSE_D9AC_PID) },
- { USB_DEVICE(FTDI_VID, ACTISENSE_D9AD_PID) },
- { USB_DEVICE(FTDI_VID, ACTISENSE_D9AE_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_UID_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_USA_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGX_PID) },
{ USB_DEVICE(FTDI_VID, ACTISENSE_D9AF_PID) },
{ USB_DEVICE(FTDI_VID, CHETCO_SEAGAUGE_PID) },
{ USB_DEVICE(FTDI_VID, CHETCO_SEASWITCH_PID) },
diff -urN linux-6.6.4/drivers/usb/serial/ftdi_sio_ids.h linux/drivers/usb/serial/ftdi_sio_ids.h
--- linux-6.6.4/drivers/usb/serial/ftdi_sio_ids.h 2023-12-03 06:33:10.000000000 +0000
+++ linux/drivers/usb/serial/ftdi_sio_ids.h 2023-12-12 10:36:37.295990528 +0000
@@ -1568,9 +1568,9 @@
#define ACTISENSE_USG_PID 0xD9A9 /* USG USB Serial Adapter */
#define ACTISENSE_NGT_PID 0xD9AA /* NGT NMEA2000 Interface */
#define ACTISENSE_NGW_PID 0xD9AB /* NGW NMEA2000 Gateway */
-#define ACTISENSE_D9AC_PID 0xD9AC /* Actisense Reserved */
-#define ACTISENSE_D9AD_PID 0xD9AD /* Actisense Reserved */
-#define ACTISENSE_D9AE_PID 0xD9AE /* Actisense Reserved */
+#define ACTISENSE_UID_PID 0xD9AC /* USB Isolating Device */
+#define ACTISENSE_USA_PID 0xD9AD /* USB to Serial Adapter */
+#define ACTISENSE_NGX_PID 0xD9AE /* NGX NMEA2000 Gateway */
#define ACTISENSE_D9AF_PID 0xD9AF /* Actisense Reserved */
#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */
#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Adapter */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ftdi_sio: Actisense PIDs constant Names
2023-12-20 13:57 ` Mark Glover
@ 2023-12-21 8:14 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2023-12-21 8:14 UTC (permalink / raw)
To: Mark Glover; +Cc: linux-usb@vger.kernel.org
On Wed, Dec 20, 2023 at 01:57:40PM +0000, Mark Glover wrote:
> This changes the constant names for unused USB PIDs (product identifiers)
> to reflect the new products now using the PIDs.
Commit messages should use imperative mode (see the process
documentation) so I changed this to:
Update the constant names for unused USB PIDs (product
identifiers) to reflect the new products now using the PIDs.
and similar in the commit summary (Subject) where I also added the
missing common prefix ("USB: serial: ").
And when revising patches you should indicate that in Subject (e.g.
"[PATCH v2]") and include a short changelog below the '---' line (which
is missing below, but goes below the SoB).
Next time, try using git format-patch to generate the patch.
> Signed-off-by: Mark Glover <mark.glover@actisense.com>
>
> diff -urN linux-6.6.4/drivers/usb/serial/ftdi_sio.c linux/drivers/usb/serial/ftdi_sio.c
> --- linux-6.6.4/drivers/usb/serial/ftdi_sio.c 2023-12-03 06:33:10.000000000 +0000
> +++ linux/drivers/usb/serial/ftdi_sio.c 2023-12-12 10:39:51.157327241 +0000
> @@ -1033,9 +1033,9 @@
> { USB_DEVICE(FTDI_VID, ACTISENSE_USG_PID) },
> { USB_DEVICE(FTDI_VID, ACTISENSE_NGT_PID) },
> { USB_DEVICE(FTDI_VID, ACTISENSE_NGW_PID) },
> - { USB_DEVICE(FTDI_VID, ACTISENSE_D9AC_PID) },
> - { USB_DEVICE(FTDI_VID, ACTISENSE_D9AD_PID) },
> - { USB_DEVICE(FTDI_VID, ACTISENSE_D9AE_PID) },
> + { USB_DEVICE(FTDI_VID, ACTISENSE_UID_PID) },
> + { USB_DEVICE(FTDI_VID, ACTISENSE_USA_PID) },
> + { USB_DEVICE(FTDI_VID, ACTISENSE_NGX_PID) },
> { USB_DEVICE(FTDI_VID, ACTISENSE_D9AF_PID) },
> { USB_DEVICE(FTDI_VID, CHETCO_SEAGAUGE_PID) },
> { USB_DEVICE(FTDI_VID, CHETCO_SEASWITCH_PID) },
For some reason that I was not able to determine, this hunk did not
apply to mainline despite that there hasn't really been any changes to
the surrounding code since 6.6.4 (which you used to generate this
patch).
I fixed it up manually this time. End result is here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=513d88a88e0203188a38f4647dd08170aebd85df
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AS8PR10MB4424F3366DA20492BA9B1605FABAA@AS8PR10MB4424.EURPRD10.PROD.OUTLOOK.COM>
[not found] ` <ZWB5VtdzyGsROpuO@hovoldconsulting.com>
[not found] ` <AS8PR10MB442424BD43EE4AECDDC93F1EFA8EA@AS8PR10MB4424.EURPRD10.PROD.OUTLOOK.COM>
[not found] ` <ZXq4A-Uht67KcJNV@hovoldconsulting.com>
2023-12-20 11:17 ` USB: ftdi_sio: Actisense PIDs constant Names Mark Glover
2023-12-20 13:26 ` Greg KH
2023-12-20 13:57 ` Mark Glover
2023-12-21 8:14 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox