[PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Frank Li]

Since dt maintainer give comments at old thread
https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/

The patch v4 already merged.
https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/

So submit new patch to rename snps,host-vbus-glitches-quirk to
snps,host-vbus-glitches to align dt maintainer's comments.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (2):
      dt-bindings: usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk
      usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++--
 drivers/usb/dwc3/core.c                              | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29
change-id: 20240207-vbus-glitch-97fd340d8a66

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>

[PATCH 1/2] dt-bindings: usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Frank Li]

Rename 'snps,host-vbus-glitches-quirk' to 'snps,host-vbus-glitches'.

Just describe the problem in the binding. So needn't 'quirk'.

Update description.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 8f5d250070c78..6685e6579e64c 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -273,11 +273,12 @@ properties:
       with an external supply.
     type: boolean
 
-  snps,host-vbus-glitches-quirk:
+  snps,host-vbus-glitches:
     description:
       When set, power off all Root Hub ports immediately after
       setting host mode to avoid vbus (negative) glitch happen in later
-      xhci reset. And the vbus will back to 5V automatically when reset done.
+      xhci reset. And the vbus will return to 5V automatically when reset
+      done.
     type: boolean
 
   snps,is-utmi-l1-suspend:

-- 
2.34.1

[PATCH 2/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Frank Li]

Rename 'snps,host-vbus-glitches-quirk' to 'snps,host-vbus-glitches'.
Just describe the problem in the binding. So needn't 'quirk'. Software
implement is workaround, so keep variable name as
'host_vbus_glitches_quirk'.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/usb/dwc3/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 3b68e8e45b8b9..2536b567efd56 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1627,7 +1627,7 @@ static void dwc3_get_properties(struct dwc3 *dwc)
 				"snps,dis-split-quirk");
 
 	dwc->host_vbus_glitches_quirk = device_property_read_bool(dev,
-				"snps,host-vbus-glitches-quirk");
+				"snps,host-vbus-glitches");
 
 	dwc->lpm_nyet_threshold = lpm_nyet_threshold;
 	dwc->tx_de_emphasis = tx_de_emphasis;

-- 
2.34.1

Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> Since dt maintainer give comments at old thread
> https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> 
> The patch v4 already merged.
> https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> 
> So submit new patch to rename snps,host-vbus-glitches-quirk to
> snps,host-vbus-glitches to align dt maintainer's comments.

I thought the last comment left on the v1 was Thinh agreeing that a
DT property was not needed here and we should be able to apply this
conditionally?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Frank Li]

On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > Since dt maintainer give comments at old thread
> > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > 
> > The patch v4 already merged.
> > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > 
> > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > snps,host-vbus-glitches to align dt maintainer's comments.
> 
> I thought the last comment left on the v1 was Thinh agreeing that a
> DT property was not needed here and we should be able to apply this
> conditionally?

I don't think so. This is workaround. We can use this track which chip
actually need this. If some year later, such chips already end of life.
We have chance to clear up these code. Otherwise, it will keep there for
ever.

And I am not sure that the side effect for other chips. Workaround should
be applied as less as possible.

Frank

Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Wed, Feb 07, 2024 at 05:14:01PM -0500, Frank Li wrote:
> On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> > On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > > Since dt maintainer give comments at old thread
> > > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > > 
> > > The patch v4 already merged.
> > > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > > 
> > > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > > snps,host-vbus-glitches to align dt maintainer's comments.
> > 
> > I thought the last comment left on the v1 was Thinh agreeing that a
> > DT property was not needed here and we should be able to apply this
> > conditionally?
> 
> I don't think so. This is workaround. We can use this track which chip
> actually need this. If some year later, such chips already end of life.
> We have chance to clear up these code. Otherwise, it will keep there for
> ever.

> And I am not sure that the side effect for other chips. Workaround should
> be applied as less as possible.

I'd rather do it unconditionally if we can, but if you and Thinh think
that we cannot do it unconditionally then sure, keep the property.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Thinh Nguyen]

On Thu, Feb 08, 2024, Conor Dooley wrote:
> On Wed, Feb 07, 2024 at 05:14:01PM -0500, Frank Li wrote:
> > On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> > > On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > > > Since dt maintainer give comments at old thread
> > > > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > > > 
> > > > The patch v4 already merged.
> > > > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > > > 
> > > > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > > > snps,host-vbus-glitches to align dt maintainer's comments.
> > > 
> > > I thought the last comment left on the v1 was Thinh agreeing that a
> > > DT property was not needed here and we should be able to apply this
> > > conditionally?
> > 
> > I don't think so. This is workaround. We can use this track which chip
> > actually need this. If some year later, such chips already end of life.
> > We have chance to clear up these code. Otherwise, it will keep there for
> > ever.
> 
> > And I am not sure that the side effect for other chips. Workaround should
> > be applied as less as possible.
> 
> I'd rather do it unconditionally if we can, but if you and Thinh think
> that we cannot do it unconditionally then sure, keep the property.
> 

Perhaps I wasn't clear. I meant I agree that we don't need a new quirk
property. If anything, it should be safer to keep vbus disabled before
handing over to xhci driver. We should be able to do this
unconditionally.

BR,
Thinh

Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

[Frank Li]

On Thu, Feb 08, 2024 at 10:28:22PM +0000, Thinh Nguyen wrote:
> On Thu, Feb 08, 2024, Conor Dooley wrote:
> > On Wed, Feb 07, 2024 at 05:14:01PM -0500, Frank Li wrote:
> > > On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> > > > On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > > > > Since dt maintainer give comments at old thread
> > > > > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > > > > 
> > > > > The patch v4 already merged.
> > > > > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > > > > 
> > > > > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > > > > snps,host-vbus-glitches to align dt maintainer's comments.
> > > > 
> > > > I thought the last comment left on the v1 was Thinh agreeing that a
> > > > DT property was not needed here and we should be able to apply this
> > > > conditionally?
> > > 
> > > I don't think so. This is workaround. We can use this track which chip
> > > actually need this. If some year later, such chips already end of life.
> > > We have chance to clear up these code. Otherwise, it will keep there for
> > > ever.
> > 
> > > And I am not sure that the side effect for other chips. Workaround should
> > > be applied as less as possible.
> > 
> > I'd rather do it unconditionally if we can, but if you and Thinh think
> > that we cannot do it unconditionally then sure, keep the property.
> > 
> 
> Perhaps I wasn't clear. I meant I agree that we don't need a new quirk
> property. If anything, it should be safer to keep vbus disabled before
> handing over to xhci driver. We should be able to do this
> unconditionally.

Okay, if everyone think unconditional is good. I can submit new patch to
remove these.

Frank

> 
> BR,
> Thinh