Linux USB
 help / color / mirror / Atom feed
From: "Christian A. Ehrhardt" <lk@c--e.de>
To: linux-kernel@vger.kernel.org
Cc: "Christian A. Ehrhardt" <lk@c--e.de>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Prashant Malani" <pmalani@chromium.org>,
	"Jameson Thies" <jthies@google.com>,
	"Abhishek Pandit-Subedi" <abhishekpandit@chromium.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Samuel Čavoj" <samuel@cavoj.net>,
	linux-usb@vger.kernel.org, "Kenneth Crudup" <kenny@panix.com>
Subject: [PATCH 3/5] usb: typec: ucsi: Ack unsupported commands
Date: Wed, 20 Mar 2024 08:39:24 +0100	[thread overview]
Message-ID: <20240320073927.1641788-4-lk@c--e.de> (raw)
In-Reply-To: <20240320073927.1641788-1-lk@c--e.de>

If a command completes the OPM must send an ack. This applies
to unsupported commands, too.

Send the required ACK for unsupported commands.

Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
---
 drivers/usb/typec/ucsi/ucsi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index dceeed207569..63f340dbd867 100644
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -151,8 +151,12 @@ static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd)
 	if (!(cci & UCSI_CCI_COMMAND_COMPLETE))
 		return -EIO;
 
-	if (cci & UCSI_CCI_NOT_SUPPORTED)
+	if (cci & UCSI_CCI_NOT_SUPPORTED) {
+		if (ucsi_acknowledge_command(ucsi) < 0)
+			dev_err(ucsi->dev,
+				"ACK of unsupported command failed\n");
 		return -EOPNOTSUPP;
+	}
 
 	if (cci & UCSI_CCI_ERROR) {
 		if (cmd == UCSI_GET_ERROR_STATUS)
-- 
2.40.1


  parent reply	other threads:[~2024-03-20  7:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20  7:39 [PATCH 0/5] Fix various races in UCSI Christian A. Ehrhardt
2024-03-20  7:39 ` [PATCH 1/5] usb: typec: ucsi: Clear EVENT_PENDING under PPM lock Christian A. Ehrhardt
2024-03-22  9:53   ` Heikki Krogerus
2024-03-20  7:39 ` [PATCH 2/5] usb: typec: ucsi: Check for notifications after init Christian A. Ehrhardt
2024-03-22  9:54   ` Heikki Krogerus
2024-03-29 16:21   ` Dmitry Baryshkov
2024-04-01 20:11     ` Christian A. Ehrhardt
2024-03-20  7:39 ` Christian A. Ehrhardt [this message]
2024-03-22 10:04   ` [PATCH 3/5] usb: typec: ucsi: Ack unsupported commands Heikki Krogerus
2024-03-20  7:39 ` [PATCH 4/5] usb: typec: ucsi_acpi: Refactor and fix DELL quirk Christian A. Ehrhardt
2024-03-22 10:00   ` Heikki Krogerus
2024-03-20  7:39 ` [PATCH 5/5] usb: typec: ucsi: Clear UCSI_CCI_RESET_COMPLETE before reset Christian A. Ehrhardt
2024-03-22 10:06   ` Heikki Krogerus
2024-12-15 18:34   ` Sasha Levin
2024-12-16 21:47     ` Christian A. Ehrhardt
2024-12-17  4:24       ` Gopal, Saranya
2024-12-18 13:58         ` Gopal, Saranya
2025-01-19 13:23       ` Fedor Pchelkin
2025-01-22 21:11         ` Christian A. Ehrhardt
2025-01-28 13:58           ` Fedor Pchelkin
2025-01-28 14:04             ` Fedor Pchelkin
2024-03-20 10:53 ` [PATCH 0/5] Fix various races in UCSI Kenneth Crudup
2024-03-22 10:57   ` Neil Armstrong
2024-03-22 10:02 ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240320073927.1641788-4-lk@c--e.de \
    --to=lk@c--e.de \
    --cc=abhishekpandit@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jthies@google.com \
    --cc=kenny@panix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=pmalani@chromium.org \
    --cc=samuel@cavoj.net \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox