public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: linux-usb@vger.kernel.org
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] usb: dwc3: gadget: Inform system of suspended state
Date: Mon, 3 Jun 2024 15:13:04 +0200	[thread overview]
Message-ID: <20240603131304.233403-1-mike.looijmans@topic.nl> (raw)
In-Reply-To: 1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.c5f44c79-75b2-43c1-a791-806fe8b693cd@emailsignatures365.codetwo.com

When disconnecting the USB cable on an LS1028 device, nothing happens
in userspace, which keeps thinking everything is still up and running.
Turns out that the DWC3 controller only sends DWC3_DEVICE_EVENT_SUSPEND
in that case, and not a DWC3_DEVICE_EVENT_DISCONNECT as one would
expect. As a result, sysfs attribute "state" remains "configured"
until something resets it.

Forward the "suspended" state to sysfs, so that the "state" at least
changes into "suspended" when one removes the cable, and hence also
matches the gadget's state when really suspended.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---

 drivers/usb/dwc3/gadget.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 4df2661f6675..99e8ea9db600 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4343,6 +4343,7 @@ static void dwc3_gadget_suspend_interrupt(struct dwc3 *dwc,
 	if (!dwc->suspended && next == DWC3_LINK_STATE_U3) {
 		dwc->suspended = true;
 		dwc3_suspend_gadget(dwc);
+		usb_gadget_set_state(dwc->gadget, USB_STATE_SUSPENDED);
 	}
 
 	dwc->link_state = next;
-- 
2.34.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl

Please consider the environment before printing this e-mail

       reply	other threads:[~2024-06-03 13:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.c5f44c79-75b2-43c1-a791-806fe8b693cd@emailsignatures365.codetwo.com>
2024-06-03 13:13 ` Mike Looijmans [this message]
2024-06-04  1:03   ` [PATCH] usb: dwc3: gadget: Inform system of suspended state Thinh Nguyen
2024-06-04  5:26     ` Mike Looijmans
2024-06-04  6:45       ` Krishna Kurapati PSSNV
2024-06-04  8:25         ` Mike Looijmans
2024-06-04  8:52           ` Krishna Kurapati PSSNV
2024-06-04 23:06       ` Thinh Nguyen
2024-06-05 14:32         ` Mike Looijmans
2024-06-06  0:28           ` Thinh Nguyen
2024-06-06  5:52             ` Mike Looijmans
2024-06-06 15:11             ` Mike Looijmans
2024-06-06 20:21               ` Thinh Nguyen
2024-06-07  6:10                 ` Mike Looijmans
2024-06-07 22:57                   ` Thinh Nguyen
2024-06-11  4:59                     ` Mike Looijmans
2024-06-11  8:02                     ` Mike Looijmans
2024-06-13  0:32                       ` Thinh Nguyen
2024-06-13  8:51                         ` Mike Looijmans
2024-06-17 23:46                           ` Thinh Nguyen
2024-06-18  0:26                             ` Thinh Nguyen
2024-06-05 14:41         ` Mike Looijmans
2024-06-06  0:29           ` Thinh Nguyen
2026-03-05  9:45             ` Ravineet Singh
2026-03-06  2:06               ` Thinh Nguyen
2026-03-06 12:07                 ` Ravineet Singh
2026-03-06 23:05                   ` Thinh Nguyen
2026-03-09  9:52                     ` Ravineet Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240603131304.233403-1-mike.looijmans@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox