From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH 0/4] Add device links between tunneled USB3 devices and USB4 Host
Date: Thu, 20 Jun 2024 09:41:15 +0300 [thread overview]
Message-ID: <20240620064115.GH1532424@black.fi.intel.com> (raw)
In-Reply-To: <20240619130305.2617784-1-mathias.nyman@linux.intel.com>
+CC Mario from AMD side to check that we are good and don't break
anything accidentally.
On Wed, Jun 19, 2024 at 04:03:01PM +0300, Mathias Nyman wrote:
> The relationship between a USB4 Host Interface providing USB3 tunnels,
> and tunneled USB3 devices is not represented in device hierarchy.
>
> This caused issues with power managment as devices may suspend and
> resume in incorrect order.
> A device link between the USB4 Host Interface and the USB3 xHCI was
> originally added to solve this, preventing the USB4 Host Interface from
> suspending if the USB3 xHCI Host was still active.
> This unfortunately also prevents USB4 Host Interface from suspending even
> if the USB3 xHCI Host is only serving native non-tunneled USB devices.
>
> Improve the current powermanagement situation by creating device links
> directly from tunneled USB3 devices to the USB4 Host Interface they depend
> on instead of a device link between the hosts.
> This way USB4 host may suspend when the last tunneled device is
> disconnected.
>
> Intel xHCI hosts are capable of reporting if connected USB3 devices are
> tunneled via vendor specific capabilities.
> Use this until a standard way is available.
>
> Mathias Nyman (4):
> xhci: Add USB4 tunnel detection for USB3 devices on Intel hosts
> usb: Add tunneled parameter to usb device structure
> usb: acpi: add device link between tunneled USB3 device and USB4 Host
> Interface
> thunderbolt: Don't create device link from USB4 Host Interface to USB3
> xHC host
>
> drivers/thunderbolt/acpi.c | 40 ++++++------------------
> drivers/usb/core/usb-acpi.c | 52 ++++++++++++++++++++++++++++++++
> drivers/usb/host/xhci-ext-caps.h | 5 +++
> drivers/usb/host/xhci-hub.c | 29 ++++++++++++++++++
> drivers/usb/host/xhci.c | 12 ++++++++
> drivers/usb/host/xhci.h | 1 +
> include/linux/usb.h | 2 ++
> 7 files changed, 111 insertions(+), 30 deletions(-)
>
> --
> 2.25.1
next prev parent reply other threads:[~2024-06-20 6:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 13:03 [PATCH 0/4] Add device links between tunneled USB3 devices and USB4 Host Mathias Nyman
2024-06-19 13:03 ` [PATCH 1/4] xhci: Add USB4 tunnel detection for USB3 devices on Intel hosts Mathias Nyman
2024-06-19 13:03 ` [PATCH 2/4] usb: Add tunneled parameter to usb device structure Mathias Nyman
2024-06-19 13:03 ` [PATCH 3/4] usb: acpi: add device link between tunneled USB3 device and USB4 Host Interface Mathias Nyman
2024-06-19 13:03 ` [PATCH 4/4] thunderbolt: Don't create device link from USB4 Host Interface to USB3 xHC host Mathias Nyman
2024-06-20 6:41 ` Mika Westerberg [this message]
2024-06-20 18:36 ` [PATCH 0/4] Add device links between tunneled USB3 devices and USB4 Host Mario Limonciello
2024-06-21 6:19 ` Mika Westerberg
2024-06-21 16:30 ` Mario Limonciello
2024-06-24 4:59 ` Mika Westerberg
2024-06-24 18:41 ` Mario Limonciello
2024-06-25 5:02 ` Mika Westerberg
2024-06-25 14:37 ` Mathias Nyman
2024-06-25 14:45 ` Mika Westerberg
2024-06-25 14:55 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620064115.GH1532424@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox