From: Greg KH <gregkh@linuxfoundation.org>
To: Shivani Gupta <shivani07g@gmail.com>
Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
mathias.nyman@intel.com, linux-usb@vger.kernel.org,
skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH] usb: xhci: Fix compiler warning in xhci.c
Date: Tue, 9 Jul 2024 07:11:49 +0200 [thread overview]
Message-ID: <2024070912-tigress-glacier-273d@gregkh> (raw)
In-Reply-To: <20240709030604.1347546-1-shivani07g@gmail.com>
On Tue, Jul 09, 2024 at 03:06:04AM +0000, Shivani Gupta wrote:
> Fixes the following compiler warnings by changing the comment syntax
> from "/**" to "/*" in the specified comments:
That's not a normal compiler warning, but rather a documentation builder
warning, right?
>
> drivers/usb/host/xhci.c:1369: warning: Function parameter or struct member
> 'desc' not described in 'xhci_get_endpoint_index'
>
> Signed-off-by: Shivani Gupta <shivani07g@gmail.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 37eb37b0affa..67168661aa52 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1355,7 +1355,7 @@ static void xhci_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
> usb_hcd_unmap_urb_for_dma(hcd, urb);
> }
>
> -/**
> +/*
This feels wrong, why not fix up the kerneldoc instead?
thanks,
greg k-h
prev parent reply other threads:[~2024-07-09 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 3:06 [PATCH] usb: xhci: Fix compiler warning in xhci.c Shivani Gupta
2024-07-09 5:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070912-tigress-glacier-273d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mchehab@kernel.org \
--cc=shivani07g@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox