* [PATCH] usb: xhci: Fix compiler warning in xhci.c
@ 2024-07-09 3:06 Shivani Gupta
2024-07-09 5:11 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Shivani Gupta @ 2024-07-09 3:06 UTC (permalink / raw)
To: laurent.pinchart, mchehab
Cc: Shivani Gupta, linux-media, linux-kernel, mathias.nyman, gregkh,
linux-usb, skhan, javier.carrasco.cruz
Fixes the following compiler warnings by changing the comment syntax
from "/**" to "/*" in the specified comments:
drivers/usb/host/xhci.c:1369: warning: Function parameter or struct member
'desc' not described in 'xhci_get_endpoint_index'
Signed-off-by: Shivani Gupta <shivani07g@gmail.com>
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 37eb37b0affa..67168661aa52 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -1355,7 +1355,7 @@ static void xhci_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
usb_hcd_unmap_urb_for_dma(hcd, urb);
}
-/**
+/*
* xhci_get_endpoint_index - Used for passing endpoint bitmasks between the core and
* HCDs. Find the index for an endpoint given its descriptor. Use the return
* value to right shift 1 for the bitmask.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: xhci: Fix compiler warning in xhci.c
2024-07-09 3:06 [PATCH] usb: xhci: Fix compiler warning in xhci.c Shivani Gupta
@ 2024-07-09 5:11 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-07-09 5:11 UTC (permalink / raw)
To: Shivani Gupta
Cc: laurent.pinchart, mchehab, linux-media, linux-kernel,
mathias.nyman, linux-usb, skhan, javier.carrasco.cruz
On Tue, Jul 09, 2024 at 03:06:04AM +0000, Shivani Gupta wrote:
> Fixes the following compiler warnings by changing the comment syntax
> from "/**" to "/*" in the specified comments:
That's not a normal compiler warning, but rather a documentation builder
warning, right?
>
> drivers/usb/host/xhci.c:1369: warning: Function parameter or struct member
> 'desc' not described in 'xhci_get_endpoint_index'
>
> Signed-off-by: Shivani Gupta <shivani07g@gmail.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 37eb37b0affa..67168661aa52 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1355,7 +1355,7 @@ static void xhci_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
> usb_hcd_unmap_urb_for_dma(hcd, urb);
> }
>
> -/**
> +/*
This feels wrong, why not fix up the kerneldoc instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-09 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 3:06 [PATCH] usb: xhci: Fix compiler warning in xhci.c Shivani Gupta
2024-07-09 5:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox