Linux USB
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: "Russell King" <linux@armlinux.org.uk>,
	"Doug Anderson" <dianders@chromium.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Jassi Brar" <jassisinghbrar@gmail.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Minas Harutyunyan" <hminas@synopsys.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Lukas Wunner <lukas@wunner.de>,
	Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kernel-list@raspberrypi.com, Stefan Wahren <wahrenst@gmx.net>
Subject: [PATCH V3 4/9] drm/vc4: hdmi: add PM suspend/resume support
Date: Wed, 21 Aug 2024 23:40:47 +0200	[thread overview]
Message-ID: <20240821214052.6800-5-wahrenst@gmx.net> (raw)
In-Reply-To: <20240821214052.6800-1-wahrenst@gmx.net>

Add suspend/resume support for the VC4 HDMI component in order
to handle suspend to idle properly. Since the HDMI power domain
is powered down during suspend, this makes connector status polling
pointless.

Link: https://lore.kernel.org/dri-devel/7003512d-7303-4f41-b0d6-a8af5bf8e497@gmx.net/
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Acked-by: Maxime Ripard <mripard@kernel.org>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 6611ab7c26a6..f7a4ed16094e 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -3104,6 +3104,31 @@ static int vc5_hdmi_init_resources(struct drm_device *drm,
 	return 0;
 }

+static int vc4_hdmi_suspend(struct device *dev)
+{
+	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
+	struct drm_device *drm = vc4_hdmi->connector.dev;
+
+	if (drm && drm->mode_config.poll_enabled)
+		drm_kms_helper_poll_disable(drm);
+
+	return pm_runtime_force_suspend(dev);
+}
+
+static int vc4_hdmi_resume(struct device *dev)
+{
+	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
+	struct drm_device *drm = vc4_hdmi->connector.dev;
+	int ret;
+
+	ret = pm_runtime_force_resume(dev);
+
+	if (drm && drm->mode_config.poll_enabled)
+		drm_kms_helper_poll_enable(drm);
+
+	return ret;
+}
+
 static int vc4_hdmi_runtime_suspend(struct device *dev)
 {
 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
@@ -3405,6 +3430,7 @@ static const struct dev_pm_ops vc4_hdmi_pm_ops = {
 	SET_RUNTIME_PM_OPS(vc4_hdmi_runtime_suspend,
 			   vc4_hdmi_runtime_resume,
 			   NULL)
+	SET_SYSTEM_SLEEP_PM_OPS(vc4_hdmi_suspend, vc4_hdmi_resume)
 };

 struct platform_driver vc4_hdmi_driver = {
--
2.34.1


  parent reply	other threads:[~2024-08-21 21:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 21:40 [PATCH V3 0/9] ARM: bcm2835: Implement initial S2Idle for Raspberry Pi Stefan Wahren
2024-08-21 21:40 ` [PATCH V3 1/9] mailbox: bcm2835: Fix timeout during suspend mode Stefan Wahren
2024-08-31  9:19   ` Stefan Wahren
2024-09-01 20:26     ` Jassi Brar
2024-09-01 20:57       ` Stefan Wahren
2024-08-21 21:40 ` [PATCH V3 2/9] drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get Stefan Wahren
2024-08-22 13:09   ` Maíra Canal
2024-08-21 21:40 ` [PATCH V3 3/9] drm/vc4: Get the rid of DRM_ERROR() Stefan Wahren
2024-08-22 13:10   ` Maíra Canal
2024-08-21 21:40 ` Stefan Wahren [this message]
2024-08-22 12:10   ` [PATCH V3 4/9] drm/vc4: hdmi: add PM suspend/resume support kernel test robot
2024-08-21 21:40 ` [PATCH V3 5/9] drm/vc4: v3d: simplify clock retrieval Stefan Wahren
2024-08-22 13:12   ` Maíra Canal
2024-08-21 21:40 ` [PATCH V3 6/9] drm/vc4: v3d: add PM suspend/resume support Stefan Wahren
2024-08-21 21:40 ` [PATCH V3 7/9] usb: dwc2: Refactor backup/restore of registers Stefan Wahren
2024-08-22  9:16   ` kernel test robot
2024-08-22 10:30   ` Stefan Wahren
2024-08-21 21:40 ` [PATCH V3 RFC 8/9] usb: dwc2: Implement recovery after PM domain off Stefan Wahren
2024-08-29 19:33   ` Doug Anderson
2024-08-21 22:36 ` [PATCH V3 9/9] ARM: bcm2835_defconfig: Enable SUSPEND Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240821214052.6800-5-wahrenst@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=Arthur.Petrosyan@synopsys.com \
    --cc=airlied@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=daniel@ffwll.ch \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=kernel-list@raspberrypi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lukas@wunner.de \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=mripard@kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox