Re: [PATCH v3 4/4] usb: typec: ucsi: Add support for the partner USB Modes

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Oct 11, 2024 at 03:44:02PM +0300, Heikki Krogerus wrote:
> UCSI does not share the contents of the Enter_USB Message
> that was used, so the active mode still has to be always
> determined from the enumerated USB device. However, after
> UCSI v2.0 it is possible to check separately is USB4 the
> active mode.
> 
> So with USB2 and USB3 the mode is always determined from the
> result of the USB enumeration, and when USB4 USB Mode is
> active, UCSI driver can assign the mode directly.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/usb/typec/ucsi/ucsi.c | 8 ++++++++
>  drivers/usb/typec/ucsi/ucsi.h | 2 ++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 13c739d334c4..804f7f9b35ea 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1057,6 +1057,14 @@ static int ucsi_register_partner(struct ucsi_connector *con)
>  
>  	con->partner = partner;
>  
> +	if (con->ucsi->version >= UCSI_VERSION_3_0)
> +		if (UCSI_CONSTAT_PARTNER_FLAGS(con->status.flags) &
> +		    UCSI_CONSTAT_PARTNER_FLAG_USB4_GEN4)
> +			typec_partner_set_usb_mode(partner, USB_MODE_USB4);
> +	if (con->ucsi->version >= UCSI_VERSION_2_0)
> +		if (UCSI_CONSTAT_PARTNER_FLAGS(con->status.flags) &
> +		    UCSI_CONSTAT_PARTNER_FLAG_USB4_GEN3)
> +			typec_partner_set_usb_mode(partner, USB_MODE_USB4);

Will this cause multiple set mode uevents to go out if both of these are
true?

thanks,

greg k-h