Re: [PATCH v3 1/4] usb: typec: Add attribute file showing the supported USB modes of the port

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

> > > > @@ -240,6 +251,7 @@ struct typec_partner_desc {
> > > >   * @port_type_set: Set port type
> > > >   * @pd_get: Get available USB Power Delivery Capabilities.
> > > >   * @pd_set: Set USB Power Delivery Capabilities.
> > > > + * @default_usb_mode_set: USB Mode to be used by default with Enter_USB Message
> > > >   */
> > > >  struct typec_operations {
> > > >     int (*try_role)(struct typec_port *port, int role);
> > > > @@ -250,6 +262,7 @@ struct typec_operations {
> > > >                          enum typec_port_type type);
> > > >     struct usb_power_delivery **(*pd_get)(struct typec_port *port);
> > > >     int (*pd_set)(struct typec_port *port, struct usb_power_delivery *pd);
> > > > +   int (*default_usb_mode_set)(struct typec_port *port, enum usb_mode mode);
> > >
> > > Naming is hard, but usually it's "noun_verb" so wouldn't this be just
> > > "mode_set_default"?  We know it's usb :)
> > >
> > > But why default, why not just "mode_set"?  or "set_mode" given you have
> > > "try_role" here, but then you have "pd_set".  Ick, I don't know, it's
> > > your code, so your call, nevermind...
> >
> > I think I'll just change it this back to the way it was in the last
> > version, and drop "default" from the name.
> 
> What's being set underneath is what USB mode to enter on the next
> reset or attach -- i.e. the default USB mode to enter. So appropriate
> naming here may be one of usb_set_default, usb_set_next. Dropping
> "usb" makes less sense vs dropping "mode", which could also refer to
> alternate modes so I'd prefer we don't call it mode_set.

I'll keep it the way it is now. This is kernel internal stuff, so we
can always change it later.

thanks,

-- 
heikki