From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gordon - <gordon.xwj@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
Jonathan Corbet <corbet@lwn.net>,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.
Date: Tue, 24 Dec 2024 06:52:10 +0100 [thread overview]
Message-ID: <2024122456-verse-giblet-9870@gregkh> (raw)
In-Reply-To: <CAD2T5m-kZAqeR3fSXHVDtevLkU0FynriwM+tb==eYaNXvVhb=g@mail.gmail.com>
On Tue, Dec 24, 2024 at 11:00:38AM +0800, Gordon - wrote:
> On Tue, Dec 24, 2024 at 1:11 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
> >
> > On 12/23/24 02:04, Gordon Ou wrote:
> > > Corrects byte offsets for OP_REP_IMPORT.
> >
> > Add more information on why this change is needed.
> >
>
> The change is needed to correct the mistaken byte offset of the field
> bDeviceClass in OP_REP_IMPORT documentation. The previous field bcdDevice
> has length 2 and the offset for bDeviceClass should be 0x138 + 2 = 0x13A
> instead of 0x139. Offsets for subsequent fields are also affected and fixed
> in this patch.
Great, please include that in the changelog text when you resend this.
thanks,
greg k-h
prev parent reply other threads:[~2024-12-24 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 9:04 [PATCH] Update USB/IP OP_REP_IMPORT documentation Gordon Ou
2024-12-23 17:11 ` Shuah Khan
2024-12-24 3:00 ` Gordon -
2024-12-24 5:52 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024122456-verse-giblet-9870@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=gordon.xwj@gmail.com \
--cc=i@zenithal.me \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=trivial@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox