* [PATCH] Update USB/IP OP_REP_IMPORT documentation.
@ 2024-12-23 9:04 Gordon Ou
2024-12-23 17:11 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Gordon Ou @ 2024-12-23 9:04 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan
Cc: Hongren Zheng, Greg Kroah-Hartman, Jonathan Corbet, linux-usb,
linux-doc, linux-kernel, trivial, Gordon Ou
Corrects byte offsets for OP_REP_IMPORT.
Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
---
Documentation/usb/usbip_protocol.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
index adc158967cc6..3da1df3d94f5 100644
--- a/Documentation/usb/usbip_protocol.rst
+++ b/Documentation/usb/usbip_protocol.rst
@@ -285,17 +285,17 @@ OP_REP_IMPORT:
+-----------+--------+------------+---------------------------------------------------+
| 0x138 | 2 | | bcdDevice |
+-----------+--------+------------+---------------------------------------------------+
-| 0x139 | 1 | | bDeviceClass |
+| 0x13A | 1 | | bDeviceClass |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13A | 1 | | bDeviceSubClass |
+| 0x13B | 1 | | bDeviceSubClass |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13B | 1 | | bDeviceProtocol |
+| 0x13C | 1 | | bDeviceProtocol |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13C | 1 | | bConfigurationValue |
+| 0x13D | 1 | | bConfigurationValue |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13D | 1 | | bNumConfigurations |
+| 0x13E | 1 | | bNumConfigurations |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13E | 1 | | bNumInterfaces |
+| 0x13F | 1 | | bNumInterfaces |
+-----------+--------+------------+---------------------------------------------------+
The following four commands have a common basic header called
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.
2024-12-23 9:04 [PATCH] Update USB/IP OP_REP_IMPORT documentation Gordon Ou
@ 2024-12-23 17:11 ` Shuah Khan
2024-12-24 3:00 ` Gordon -
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2024-12-23 17:11 UTC (permalink / raw)
To: Gordon Ou, Valentina Manea, Shuah Khan
Cc: Hongren Zheng, Greg Kroah-Hartman, Jonathan Corbet, linux-usb,
linux-doc, linux-kernel, trivial, Shuah Khan
On 12/23/24 02:04, Gordon Ou wrote:
> Corrects byte offsets for OP_REP_IMPORT.
Add more information on why this change is needed.
>
> Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
> ---
> Documentation/usb/usbip_protocol.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
> index adc158967cc6..3da1df3d94f5 100644
> --- a/Documentation/usb/usbip_protocol.rst
> +++ b/Documentation/usb/usbip_protocol.rst
> @@ -285,17 +285,17 @@ OP_REP_IMPORT:
> +-----------+--------+------------+---------------------------------------------------+
> | 0x138 | 2 | | bcdDevice |
> +-----------+--------+------------+---------------------------------------------------+
> -| 0x139 | 1 | | bDeviceClass |
> +| 0x13A | 1 | | bDeviceClass |
> +-----------+--------+------------+---------------------------------------------------+
> -| 0x13A | 1 | | bDeviceSubClass |
> +| 0x13B | 1 | | bDeviceSubClass |
> +-----------+--------+------------+---------------------------------------------------+
> -| 0x13B | 1 | | bDeviceProtocol |
> +| 0x13C | 1 | | bDeviceProtocol |
> +-----------+--------+------------+---------------------------------------------------+
> -| 0x13C | 1 | | bConfigurationValue |
> +| 0x13D | 1 | | bConfigurationValue |
> +-----------+--------+------------+---------------------------------------------------+
> -| 0x13D | 1 | | bNumConfigurations |
> +| 0x13E | 1 | | bNumConfigurations |
> +-----------+--------+------------+---------------------------------------------------+
> -| 0x13E | 1 | | bNumInterfaces |
> +| 0x13F | 1 | | bNumInterfaces |
> +-----------+--------+------------+---------------------------------------------------+
>
> The following four commands have a common basic header called
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.
2024-12-23 17:11 ` Shuah Khan
@ 2024-12-24 3:00 ` Gordon -
2024-12-24 5:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Gordon - @ 2024-12-24 3:00 UTC (permalink / raw)
To: Shuah Khan
Cc: Valentina Manea, Shuah Khan, Hongren Zheng, Greg Kroah-Hartman,
Jonathan Corbet, linux-usb, linux-doc, linux-kernel, trivial
On Tue, Dec 24, 2024 at 1:11 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 12/23/24 02:04, Gordon Ou wrote:
> > Corrects byte offsets for OP_REP_IMPORT.
>
> Add more information on why this change is needed.
>
The change is needed to correct the mistaken byte offset of the field
bDeviceClass in OP_REP_IMPORT documentation. The previous field bcdDevice
has length 2 and the offset for bDeviceClass should be 0x138 + 2 = 0x13A
instead of 0x139. Offsets for subsequent fields are also affected and fixed
in this patch.
> >
> > Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
> > ---
> > Documentation/usb/usbip_protocol.rst | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
> > index adc158967cc6..3da1df3d94f5 100644
> > --- a/Documentation/usb/usbip_protocol.rst
> > +++ b/Documentation/usb/usbip_protocol.rst
> > @@ -285,17 +285,17 @@ OP_REP_IMPORT:
> > +-----------+--------+------------+---------------------------------------------------+
> > | 0x138 | 2 | | bcdDevice |
> > +-----------+--------+------------+---------------------------------------------------+
> > -| 0x139 | 1 | | bDeviceClass |
> > +| 0x13A | 1 | | bDeviceClass |
> > +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13A | 1 | | bDeviceSubClass |
> > +| 0x13B | 1 | | bDeviceSubClass |
> > +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13B | 1 | | bDeviceProtocol |
> > +| 0x13C | 1 | | bDeviceProtocol |
> > +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13C | 1 | | bConfigurationValue |
> > +| 0x13D | 1 | | bConfigurationValue |
> > +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13D | 1 | | bNumConfigurations |
> > +| 0x13E | 1 | | bNumConfigurations |
> > +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13E | 1 | | bNumInterfaces |
> > +| 0x13F | 1 | | bNumInterfaces |
> > +-----------+--------+------------+---------------------------------------------------+
> >
> > The following four commands have a common basic header called
>
> thanks,
> -- Shuah
Thanks for the reply, please find my update inline, and let me know if an
updated patch is needed.
Gordon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.
2024-12-24 3:00 ` Gordon -
@ 2024-12-24 5:52 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-24 5:52 UTC (permalink / raw)
To: Gordon -
Cc: Shuah Khan, Valentina Manea, Shuah Khan, Hongren Zheng,
Jonathan Corbet, linux-usb, linux-doc, linux-kernel, trivial
On Tue, Dec 24, 2024 at 11:00:38AM +0800, Gordon - wrote:
> On Tue, Dec 24, 2024 at 1:11 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
> >
> > On 12/23/24 02:04, Gordon Ou wrote:
> > > Corrects byte offsets for OP_REP_IMPORT.
> >
> > Add more information on why this change is needed.
> >
>
> The change is needed to correct the mistaken byte offset of the field
> bDeviceClass in OP_REP_IMPORT documentation. The previous field bcdDevice
> has length 2 and the offset for bDeviceClass should be 0x138 + 2 = 0x13A
> instead of 0x139. Offsets for subsequent fields are also affected and fixed
> in this patch.
Great, please include that in the changelog text when you resend this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-24 5:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-23 9:04 [PATCH] Update USB/IP OP_REP_IMPORT documentation Gordon Ou
2024-12-23 17:11 ` Shuah Khan
2024-12-24 3:00 ` Gordon -
2024-12-24 5:52 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox