* [PATCH v2] USB: phy: tahvo: Add check for clk_enable()
@ 2024-12-26 1:35 Mingwei Zheng
2024-12-27 12:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Mingwei Zheng @ 2024-12-26 1:35 UTC (permalink / raw)
To: gregkh
Cc: u.kleine-koenig, aaro.koskinen, balbi, linux-usb, linux-kernel,
Mingwei Zheng, Jiasheng Jiang
The APP-Miner reported the missing check.
Add check for the return value of clk_enable() to catch the potential
error.
Fixes: 9ba96ae5074c ("usb: omap1: Tahvo USB transceiver driver")
Signed-off-by: Mingwei Zheng <zmw12306@gmail.com>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
Changelog:
v1 -> v2
1. Add tool name in commit msg.
---
drivers/usb/phy/phy-tahvo.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index ae7bf3ff89ee..0b8801318cd2 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -342,8 +342,11 @@ static int tahvo_usb_probe(struct platform_device *pdev)
mutex_init(&tu->serialize);
tu->ick = devm_clk_get(&pdev->dev, "usb_l4_ick");
- if (!IS_ERR(tu->ick))
- clk_enable(tu->ick);
+ if (!IS_ERR(tu->ick)) {
+ ret = clk_enable(tu->ick);
+ if (ret)
+ return ret;
+ }
/*
* Set initial state, so that we generate kevents only on state changes.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] USB: phy: tahvo: Add check for clk_enable()
2024-12-26 1:35 [PATCH v2] USB: phy: tahvo: Add check for clk_enable() Mingwei Zheng
@ 2024-12-27 12:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-12-27 12:08 UTC (permalink / raw)
To: Mingwei Zheng
Cc: u.kleine-koenig, aaro.koskinen, balbi, linux-usb, linux-kernel,
Jiasheng Jiang
On Wed, Dec 25, 2024 at 08:35:00PM -0500, Mingwei Zheng wrote:
> The APP-Miner reported the missing check.
> Add check for the return value of clk_enable() to catch the potential
> error.
You did NOT answer all of the questions required as documented in the
./Documentation/process/researcher-guidelines.rst file, so I can't take
this, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-27 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-26 1:35 [PATCH v2] USB: phy: tahvo: Add check for clk_enable() Mingwei Zheng
2024-12-27 12:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox