From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: typec: fix const issue in typec_match()
Date: Thu, 22 May 2025 14:30:05 +0200 [thread overview]
Message-ID: <2025052244-mockup-dreadlock-bb3e@gregkh> (raw)
In-Reply-To: <aC8TH03vOhXI9IYW@kuha.fi.intel.com>
On Thu, May 22, 2025 at 03:05:51PM +0300, Heikki Krogerus wrote:
> Hi Greg,
>
> On Wed, May 21, 2025 at 03:41:27PM +0200, Greg Kroah-Hartman wrote:
> > typec_match() takes a const pointer, and then decides to cast it away
> > into a non-const one, which is not a good thing to do overall. Fix this
> > up by properly setting the pointers to be const to preserve that
> > attribute.
> >
> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Shouldn't there be a Fixes tag? git blame gives commit d69d804845985
Yes, as Johan pointed out, this is my fault :) I'll add that when I
commit this.
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
thanks for the review!
greg k-h
prev parent reply other threads:[~2025-05-22 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 13:41 [PATCH] USB: typec: fix const issue in typec_match() Greg Kroah-Hartman
2025-05-22 12:05 ` Heikki Krogerus
2025-05-22 12:30 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025052244-mockup-dreadlock-bb3e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox