Re: [PATCH] USB: typec: fix const issue in typec_match()

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi Greg,

On Wed, May 21, 2025 at 03:41:27PM +0200, Greg Kroah-Hartman wrote:
> typec_match() takes a const pointer, and then decides to cast it away
> into a non-const one, which is not a good thing to do overall.  Fix this
> up by properly setting the pointers to be const to preserve that
> attribute.
> 
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Shouldn't there be a Fixes tag? git blame gives commit d69d804845985

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

thanks,

> ---
>  drivers/usb/typec/bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c
> index ae90688d23e4..91eae95d6fa4 100644
> --- a/drivers/usb/typec/bus.c
> +++ b/drivers/usb/typec/bus.c
> @@ -449,8 +449,8 @@ ATTRIBUTE_GROUPS(typec);
>  
>  static int typec_match(struct device *dev, const struct device_driver *driver)
>  {
> -	struct typec_altmode_driver *drv = to_altmode_driver(driver);
> -	struct typec_altmode *altmode = to_typec_altmode(dev);
> +	const struct typec_altmode_driver *drv = to_altmode_driver(driver);
> +	const struct typec_altmode *altmode = to_typec_altmode(dev);
>  	const struct typec_device_id *id;
>  
>  	for (id = drv->id_table; id->svid; id++)
> -- 
> 2.49.0
> 

-- 
heikki