From: Vadym Hrynchyshyn <vadimgrn@gmail.com>
To: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
linux-usb@vger.kernel.org
Cc: Vadym Hrynchyshyn <vadimgrn@gmail.com>
Subject: [PATCH v2 1/3] usbipd: enable SO_KEEPALIVE socket option for accepted connection
Date: Fri, 23 May 2025 12:07:23 +0300 [thread overview]
Message-ID: <20250523090802.17987-2-vadimgrn@gmail.com> (raw)
In-Reply-To: <20250523090802.17987-1-vadimgrn@gmail.com>
If usbip client does not close a TCP/IP connection to a daemon
gracefully, the daemon will keep this connection open indefinitely.
The issue is that the client cannot attach this device again
until the device will be rebinded on server side by commands:
usbip unbind -b X-Y
usbip bind -b X-Y
usbip client enables tcp keepalive by calling usbip_net_set_keepalive
from usbip_net_tcp_connect. usbip daemon now enables this socket option
too for accepted connection.
Signed-off-by: Vadym Hrynchyshyn <vadimgrn@gmail.com>
---
tools/usb/usbip/src/usbipd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
index 48398a78e88a..d89633d8f799 100644
--- a/tools/usb/usbip/src/usbipd.c
+++ b/tools/usb/usbip/src/usbipd.c
@@ -119,6 +119,7 @@ static int recv_request_import(int sockfd)
if (found) {
/* should set TCP_NODELAY for usbip */
usbip_net_set_nodelay(sockfd);
+ usbip_net_set_keepalive(sockfd);
/* export device needs a TCP/IP socket descriptor */
status = usbip_export_device(edev, sockfd);
--
2.43.0
next prev parent reply other threads:[~2025-05-23 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 9:07 [PATCH v2 0/3] usbipd: enable tcp keepalive and set its options for accepted connection Vadym Hrynchyshyn
2025-05-23 9:07 ` Vadym Hrynchyshyn [this message]
2025-05-23 9:07 ` [PATCH v2 2/3] usbipd: add long options to set TCP_KEEPIDLE/TCP_KEEPCNT/TCP_KEEPINTVL socket options Vadym Hrynchyshyn
2025-05-23 9:07 ` [PATCH v2 3/3] usbipd: use usbip_to_int to simplify usbip_setup_port_number implementation Vadym Hrynchyshyn
2025-05-23 9:17 ` [PATCH v2 0/3] usbipd: enable tcp keepalive and set its options for accepted connection Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523090802.17987-2-vadimgrn@gmail.com \
--to=vadimgrn@gmail.com \
--cc=i@zenithal.me \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox